Skip to content

BBC: Blead breaks Glib #23055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eserte opened this issue Mar 2, 2025 · 3 comments
Closed

BBC: Blead breaks Glib #23055

eserte opened this issue Mar 2, 2025 · 3 comments
Labels
BBC Blead Breaks CPAN - changes in blead broke a cpan module(s)

Comments

@eserte
Copy link
Contributor

eserte commented Mar 2, 2025

The testsuite of XAOC/Glib-1.3294.tar.gz started to fail with perl 5.41.9, see http://fast-matrix.cpantesters.org/?dist=Glib%201.3294

Several test scripts fail:

...
Argument "xyz" isn't numeric in numeric eq (==) at t/5.t line 66.
t/5.t ...................... 
Failed 4/10 subtests 
Use of uninitialized value in string eq at t/6.t line 118.
Use of uninitialized value in string eq at t/6.t line 119.
Use of uninitialized value in string eq at t/6.t line 120.
Use of uninitialized value in string eq at t/6.t line 121.
Use of uninitialized value in string eq at t/6.t line 123.
Use of uninitialized value in string eq at t/6.t line 124.
Use of uninitialized value in string eq at t/6.t line 126.
Use of uninitialized value in string eq at t/6.t line 128.
t/6.t ...................... 
Failed 23/31 subtests 
...
#   Failed test '$obj->{some_string} empty'
#   at t/b.t line 69.
#          got: undef
#     expected: 'one'

#   Failed test '$obj->{read_string} empty'
#   at t/b.t line 70.
#          got: undef
#     expected: 'two'

#   Failed test '$obj->{read_string} empty'
#   at t/b.t line 78.
#          got: '44'
#     expected: 'two'
# Looks like you failed 3 tests of 8.
t/b.t ...................... 
Dubious, test returned 3 (wstat 768, 0x300)
Failed 3/8 subtests 
...
#   Failed test 'flags property'
#   at t/c.t line 226.
#     Structures begin differing at:
#          $got->[1] = 'value-five'
#     $expected->[1] = Does not exist

#   Failed test 'flags property'
#   at t/c.t line 227.
#     Structures begin differing at:
#          $got->[1] = 'value-five'
#     $expected->[1] = Does not exist
# Looks like you failed 2 tests of 57.
t/c.t ...................... 
Dubious, test returned 2 (wstat 512, 0x200)
Failed 2/57 subtests 
...
#   Failed test 'MaiTai tied store function called'
#   at t/tied_set_property.t line 55.
#          got: '0'
#     expected: '1'
# Looks like you failed 1 test of 1.
t/tied_set_property.t ...... 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/1 subtests 
...

Test Summary Report
-------------------
t/5.t                    (Wstat: 0 Tests: 8 Failed: 2)
  Failed tests:  4, 8
  Parse errors: Tests out of sequence.  Found (3) but expected (2)
                Tests out of sequence.  Found (4) but expected (3)
                Tests out of sequence.  Found (5) but expected (4)
                Tests out of sequence.  Found (6) but expected (5)
                Tests out of sequence.  Found (7) but expected (6)
Displayed the first 5 of 8 TAP syntax errors.
Re-run prove with the -p option to see them all.
t/6.t                    (Wstat: 0 Tests: 16 Failed: 8)
  Failed tests:  16-23
  Parse errors: Tests out of sequence.  Found (16) but expected (1)
                Tests out of sequence.  Found (17) but expected (2)
                Tests out of sequence.  Found (18) but expected (3)
                Tests out of sequence.  Found (19) but expected (4)
                Tests out of sequence.  Found (20) but expected (5)
Displayed the first 5 of 17 TAP syntax errors.
Re-run prove with the -p option to see them all.
t/b.t                    (Wstat: 768 (exited 3) Tests: 8 Failed: 3)
  Failed tests:  3-4, 7
  Non-zero exit status: 3
t/c.t                    (Wstat: 512 (exited 2) Tests: 57 Failed: 2)
  Failed tests:  42-43
  Non-zero exit status: 2
t/tied_set_property.t    (Wstat: 256 (exited 1) Tests: 1 Failed: 1)
  Failed test:  1
  Non-zero exit status: 1
Files=33, Tests=1176,  5 wallclock secs ( 0.26 usr  0.08 sys +  2.46 cusr  0.52 csys =  3.32 CPU)
Result: FAIL
Failed 5/33 test programs. 16/1176 subtests failed.
make: *** [Makefile:1383: test_dynamic] Error 255
@eserte eserte added BBC Blead Breaks CPAN - changes in blead broke a cpan module(s) Needs Triage labels Mar 2, 2025
@jkeenan
Copy link
Contributor

jkeenan commented Mar 3, 2025

Bisecting with this invocation:

perl Porting/bisect.pl \
--module=Glib \
--start=275243fbaf44bf18a6a42a38e62026bc22e22cc4 \
--end=v5.41.9

... pointed to the same breaking commit as reported in #23015

b9eeeef8c043fb0238a07e64636815bf327a6562 is the first bad commit
commit b9eeeef8c043fb0238a07e64636815bf327a6562
Author: Lukas Mai <[email protected]>
Date:   Fri Feb 14 21:49:03 2025 +0100
Commit:     Lukas Mai <[email protected]>
CommitDate: Sun Feb 16 01:42:36 2025 +0100

    op.c: re-enable coderef-in-stash optimization

@mauke, can you take a look? Thanks.

@haarg
Copy link
Contributor

haarg commented Mar 3, 2025

This should be fixed by #23029

@jkeenan
Copy link
Contributor

jkeenan commented Mar 18, 2025

The breaking commit has been reverted. Any re-reversion will take place in the next development cycle and be tracked in #23131. Closing this issue.

@jkeenan jkeenan closed this as completed Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BBC Blead Breaks CPAN - changes in blead broke a cpan module(s)
Projects
None yet
Development

No branches or pull requests

3 participants