From 86bf84dbaab7accb925bfc8ad21342b96f60d166 Mon Sep 17 00:00:00 2001 From: Russell Jenkins Date: Wed, 30 Oct 2024 21:48:42 +1100 Subject: [PATCH 1/3] Add Module::Pluggable as a requirement, excluding broken versions Module::Pluggable added checks for unreadable files in v6.1 and v6.2. Those tests fail when installed as root, which may happen in a docker file, such as under github actions. While we have no explicit dependency on Module::Pluggable, our dependencies do, such as Config::Any. This is a bit of a crutch until Module::Plugable is patched. Upstream issue: https://github.com/simonwistow/Module-Pluggable/issues/27 --- cpanfile | 1 + 1 file changed, 1 insertion(+) diff --git a/cpanfile b/cpanfile index 07f3246bd..c092e9a3d 100644 --- a/cpanfile +++ b/cpanfile @@ -22,6 +22,7 @@ requires 'Import::Into'; requires 'JSON::MaybeXS'; requires 'List::Util', '1.29'; # 1.29 has the pair* functions requires 'MIME::Base64', '3.13'; # 3.13 has the URL safe variants +requires 'Module::Pluggable', '!= 6.1, != 6.2'; # 6.1 and 6.2 fail their test suite when run as root requires 'Module::Runtime'; requires 'Moo', '2.000000'; requires 'Moo::Role'; From 1ff24c483a7381b8b5fd3ba3f373450097365fe0 Mon Sep 17 00:00:00 2001 From: Russell Jenkins Date: Wed, 30 Oct 2024 22:08:53 +1100 Subject: [PATCH 2/3] Alternate way to specify we do not want Module::Pluggable 6.1 or 6.2 This way we do not have to bump EUMM --- cpanfile | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/cpanfile b/cpanfile index c092e9a3d..6638c4e2c 100644 --- a/cpanfile +++ b/cpanfile @@ -22,7 +22,6 @@ requires 'Import::Into'; requires 'JSON::MaybeXS'; requires 'List::Util', '1.29'; # 1.29 has the pair* functions requires 'MIME::Base64', '3.13'; # 3.13 has the URL safe variants -requires 'Module::Pluggable', '!= 6.1, != 6.2'; # 6.1 and 6.2 fail their test suite when run as root requires 'Module::Runtime'; requires 'Moo', '2.000000'; requires 'Moo::Role'; @@ -48,6 +47,12 @@ requires 'File::Which'; requires 'Role::Tiny', '2.000000'; conflicts 'Role::Tiny', '== 2.000007'; +# Module::Pluggable 6.1 and 6.2 fail their test suite when run as root, +# such as under docker in a github action +requires 'Module::Pluggable'; +conflicts 'Module::Pluggable', '== 6.1'; +conflicts 'Module::Pluggable', '== 6.2'; + # Minimum version of YAML is needed due to: # - https://github.com/PerlDancer/Dancer2/issues/899 # Excluded 1.16 is needs due to: From e4d11c170f281f81c362b51106de532b0748d9b2 Mon Sep 17 00:00:00 2001 From: "Jason A. Crome" Date: Wed, 30 Oct 2024 08:05:45 -0400 Subject: [PATCH 3/3] reflect changes --- Changes | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Changes b/Changes index e431eacac..66915f711 100644 --- a/Changes +++ b/Changes @@ -13,8 +13,11 @@ * None [ MISC ] + * PR #1715: Update deprecated download-artifact (dependabot) * GH #1716: Remove Scope::Upper from list of recommended deps (Russell @veryrusty Jenkins) + * PR #1718: Add Module::Pluggable as a requirement, excluding + broken versions (Russell @veryrusty Jenkins) 1.1.1 2024-07-18 19:48:00-04:00 America/New_York