ETag support via middleware failed for HEAD requests.

[amaxcz]

Please add the support for ETags? Also, there is should be a way to specify params for Plack::Middleware::ETag

--- App.pm.orig 2017-03-10 22:38:06.000000000 +0100
+++ App.pm      2017-12-07 12:18:54.875253693 +0100
@@ -17,6 +17,7 @@
 use Plack::Middleware::Head;
 use Plack::Middleware::Conditional;
 use Plack::Middleware::ConditionalGET;
+use Plack::Middleware::ETag;

 use Dancer2::FileUtils 'path';
 use Dancer2::Core;
@@ -1400,6 +1401,11 @@
     # FixMissingBodyInRedirect
     $psgi = Plack::Middleware::FixMissingBodyInRedirect->wrap( $psgi );

+       # Add experimental ETag support. This should be implemented properly!
+    $psgi = Plack::Middleware::ETag->wrap( $psgi );
+    $psgi = Plack::Middleware::ConditionalGET->wrap( $psgi );
+
+
     # Only add static content handler if requires
     if ( $self->config->{'static_handler'} ) {
         # Use App::File to "serve" the static content
 

[amaxcz]

Suggested fix is here because now, Dancer2 isn't ready to serve Etags for HEAD requests (even via builder). Because HEAD requests drops body, so etags calculation for HEAD requests is not working absolutely. That is a problem.

[amaxcz]

also we SHOULD calculate Etags before ConditionalGET. and before dropping body on the HEAD requests..
so... Please implement ETag support, it's important.

[amaxcz]

Linked bugs are:
plack/Plack#606
plack/Plack#605

[cromedome]

Resolved by #1459. Closing!