Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefixes should not allow trailing slashes #593

Closed
xsawyerx opened this issue May 28, 2014 · 1 comment
Closed

Prefixes should not allow trailing slashes #593

xsawyerx opened this issue May 28, 2014 · 1 comment

Comments

@xsawyerx
Copy link
Member

In order to be consistent with false routes (issue #581), prefixes should not allow postfix slash.

If:

We could generate paths that are consistent:

  • Prefix will always connect to paths with a single /.
  • Users who want multiple slashes can add them to the route, and it will work.
  • Element of least surprise.
@xsawyerx xsawyerx changed the title Prefixes should not allow postfix slash Prefixes should not allow trailing slashes May 28, 2014
@xsawyerx
Copy link
Member Author

Now that I look at it again, I realize this might be a mistake because /admin should not be the same as /admin/. Also, HTTP protocol dictates that /admin// is different than /admin/, so that means we need to support both, even if the user is making a mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant