-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate the middleware to a builder #600
Comments
@xsawyerx I'd been thinking about something similar (as a result of working on #590). If you are considering only adding middleware, as in |
Agreed with @veryrusty, while we are at it, we could provide a full access to the $builder, provided it offers a sane and easy to use interface (not familiar with Plack::Builder) |
One thing I'm afraid of is getting back to the The difference in this issue is that it raises the option of allowing developers (specifically plugin developers) to add middlewares, rather than allow users to add middlewares. |
Renewed position: Middlewares are not application level and we shouldn't confuse them. Closing this issue. IF someone still sees this as a valued enhancement, please reopen. Thanks! |
In a discussion on plugins (#599), we raised the idea of using a
Plack::Builder
all the time, and then allow plugins to add middlewares.I know exactly how I want to implement it, in this case:
Have a Builder attribute and add
handles
to theadd_middleware
method and have that available in the DSL.This is a two part process. This issue is the first one. I'm opening another issue for the second one.
The text was updated successfully, but these errors were encountered: