Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to use either magnet or torrent links #13

Open
stevygee opened this issue Aug 16, 2015 · 4 comments
Open

Add option to use either magnet or torrent links #13

stevygee opened this issue Aug 16, 2015 · 4 comments

Comments

@stevygee
Copy link
Collaborator

No description provided.

@PeterTheOne
Copy link
Owner

(or both as they are available..)

@PeterTheOne
Copy link
Owner

didn't check in detail, but does this really solve the problem? what if config is set to magnet but there only is a torrent file.. I guess the check should start already when searching for torrents.

@PeterTheOne PeterTheOne reopened this Aug 19, 2015
@stevygee
Copy link
Collaborator Author

Right now it's just a filter of what type of link to display in feed. If config = magnet and there is only a torrent file, that entry is skipped. I do think it makes sense for both torrent and magnet links to be in the database, so it's not necessary to parse search results again if config is changed.

Some search sites only return one type of link, but it's possible to generate a magnet link out of the torrent info hash, but without tracker info. Additional testing is needed to see if these links result in a working download.

@PeterTheOne
Copy link
Owner

I see your point. There is one case where this leads to unwanted results: When one tracker is preferred over another because of the number of peers but this torrent is not the desired format (magnet or file) then the torrent is not displayed even though there was a torrent in the desired format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants