Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFR] Forum Module #25

Open
pgasiorowski opened this issue Apr 5, 2014 · 9 comments
Open

[NFR] Forum Module #25

pgasiorowski opened this issue Apr 5, 2014 · 9 comments
Labels
Milestone

Comments

@pgasiorowski
Copy link
Contributor

I have seen Forum as one of the modules to be introduced into the CMS.

What I would like to suggest is actually re-using some of the sourcecode from the official Phalcon Forum eg. https://github.com/phalcon/forum
Happy to work out a PR

@lantian lantian added the FEATURE label Apr 5, 2014
@lantian
Copy link
Contributor

lantian commented Apr 5, 2014

Agree, this is a good idea =)

@pgasiorowski
Copy link
Contributor Author

I've freed up some spare time now so should be able to jump onto this PR soon.
What I'd like to achieve is a stable port of the forum and a migration script from Joomla+Kunena
One of the site's I'm currently looking after (over 1m users) has become pretty overloaded and I seriously think about migrating it over to something else instead of doing hardcore optimizations -
and this CMS has a great potential.

@lantian
Copy link
Contributor

lantian commented Apr 26, 2014

Great news! I will freed up my time at next week, coz now I'm finishing some issues related to Crimea.

As for Phosphorum 2 - it seems that all code can be moved to PhalconEye as module without any problems, only autherization must left on PhalconEye and maybe it would be greate also to create some subsystem for different Auth API's like Github, Facebook, etc.

@pgasiorowski
Copy link
Contributor Author

I will give it a go - fork the forum, add manifest and see how for it could go.

I think that Github-repo based modules is a great idea which might simplifies things a lot.
Just grab a module-repo, download is stright from Github and install - I am not sure if there is a single CMS which does this. Thinking long-term when PhalconEye gets more popular it would be possible to create a module browser (similar to Joomla extension browser) from withing the CMS, add install button which will grab selected module and perform install - no composer needed!
Moreover the module browser might be a module itself - very decoupled and nice. What do you think?

@lantian
Copy link
Contributor

lantian commented Apr 26, 2014

Yep, i thought about that feature from first steps )))... but with time I understood that i need to do a lot... so I put it on the shelf for a better time ))

@pgasiorowski
Copy link
Contributor Author

So I got to the point where it installs and works fine. Despite a few glitches it's not that bad at all.
Initially I started with reusing/merging DI's/service locators from both the CMS and forum but I faced a wall and tried different approach with two separate DI's instead.

You can check it out at: https://github.com/WooDzu/forum I've only added these:

  • /manifest.json
  • /app/Bootstrap.php
  • /app/installer.php
  • /eye

Instructions if anybody decides to give it a go:

  1. Backup your stuff
  2. Install module's library dependencies (in cms) in given order:
  3. https://github.com/WooDzu/EventDispatcher/archive/eye.zip
  4. https://github.com/WooDzu/OptionsResolver/archive/eye.zip
  5. https://github.com/WooDzu/guzzle/archive/eye.zip
  6. https://github.com/WooDzu/Ciconia/archive/eye.zip
  7. Install the forum module:
  8. https://github.com/WooDzu/forum/archive/eye2.zip or just grab it from my GitHub fork page (loving the way!)
  9. Since there is no admin for module's parameters in the CMS yet, you'll need to update my Github secret and client ids after installation (yes it's hardcoded for now)
  10. just edit two lines here: https://github.com/WooDzu/forum/blob/eye2/app/Bootstrap.php#L213
  11. Go to http://cms-url/forum/

I tested on windows and ubuntu but you may face an exception if profiling is enabled and you're signed in Temp fixed now

This might or may not be a good starting point, we'll see. The cms is missing admin for module parameters so categories must be added manually in database before posting anything.

@lantian
Copy link
Contributor

lantian commented May 4, 2014

Interesting... This module is just like a bridge between forum and PhalconEye, it seems that this is "dirty" way, but it's cool! Thanks, I will look on it today/tomorrow. 👍

@nazwa
Copy link

nazwa commented May 4, 2014

I personally don't think it's a good idea for those two applications to be merged together. They are just so different. I think much better effects could be achieved by adding a second sign on technique to phosphorum, via a phalconeye gate. That way both applications stay separate and can be updated separately, while still allowing for 'single signon' etc.

@pgasiorowski
Copy link
Contributor Author

This bridge is really experimenting with both Phalcon and the cms, but the more time I spend on it the more "dirty" things get vanished. I do agree that dedicated cms module is the way to go

@lantian lantian added this to the 0.5.0 milestone May 16, 2014
@lantian lantian modified the milestones: 0.5.0, 0.6.0 Nov 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants