Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Use client's language instead of server's language when showing translations #44

Closed
Tiagoquix opened this issue May 8, 2021 · 4 comments
Labels
request :: general New feature or request
Milestone

Comments

@Tiagoquix
Copy link
Contributor

I see that this plugin uses the server language (LANG_SERVER) instead of a function like this. What the LANG_SERVER does is basically use this setting instead of using the client's language.

Can you change the plugin in a way that it shows the translated phrases based on the client's language and not on the server language? This is what most plugins do.

Thanks in advance.

@Tiagoquix
Copy link
Contributor Author

Tiagoquix commented May 8, 2021

There is even an option in the core.cfg file that is related to my issue/feature request.

https://github.com/alliedmodders/sourcemod/blob/master/configs/core.cfg#L76

	/**
	 * Enables or disables whether SourceMod reads a client's cl_language cvar to set 
	 * their language for server-side phrase translation.
	 *
	 * "on"		- Translate using the client's language (default)
	 * "off"	- Translate using default server's language
	 */
	"AllowClLanguageVar"		"On"

@MAGNAT2645
Copy link
Contributor

@Phil25, just replace LANG_SERVER with client index, that's all 😃

@Phil25 Phil25 added the request :: general New feature or request label Nov 24, 2023
@Phil25 Phil25 added this to the 2.4.1 milestone Nov 25, 2023
@Phil25 Phil25 modified the milestones: 2.4.1, 2.4.2 Dec 17, 2023
@Phil25 Phil25 closed this as completed in 3a45495 Dec 27, 2023
@Tiagoquix
Copy link
Contributor Author

@Phil25 Would it also be possible to have the effects' names be translatable per language as well?

@Phil25
Copy link
Owner

Phil25 commented Dec 27, 2023

@Phil25 Would it also be possible to have the effects' names be translatable per language as well?

I've taken a brief look at it per #49 and translating perk names comes with a unique set of challenges. I haven't come to a conclusion yet but I doubt I will support it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
request :: general New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants