fix: remove attributes after binding step

fixes #478
PhpGt · Dec 12, 2023 · ed08179 · ed08179
1 parent 5ab216b
commit ed08179
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 1 deletion.
diff --git a/src/HTMLAttributeBinder.php b/src/HTMLAttributeBinder.php
@@ -32,6 +32,8 @@ public function bind(
 			$element = $element->documentElement;
 		}
 
+		$attributesToRemove = [];
+
 		/**
 		 * @var string $attrName
 		 * @var Attr $attr
@@ -80,9 +82,13 @@ public function bind(
 			);
 
 			if(!$attr->ownerElement->hasAttribute("data-rebind")) {
-				$attr->ownerElement->removeAttribute($attrName);
+				array_push($attributesToRemove, $attrName);
 			}
 		}
+
+		foreach($attributesToRemove as $attrName) {
+			$element->removeAttribute($attrName);
+		}
 	}
 
 	public function expandAttributes(Element $element):void {

diff --git a/test/phpunit/HTMLAttributeBinderTest.php b/test/phpunit/HTMLAttributeBinderTest.php
@@ -127,4 +127,17 @@ public function testBind_dateTimeInterface():void {
 		$sut->bind(null, $dateTime, $outputElement);
 		self::assertSame("Tue, 05 Apr 1988 17:23:00 GMT", $outputElement->textContent);
 	}
+
+	public function testBind_multipleBindAttributes():void {
+		$document = new HTMLDocument(HTMLPageContent::HTML_MULTIPLE_BIND_ATTRIBUTES);
+		$sut = new HTMLAttributeBinder();
+		$link1 = $document->getElementById("link1");
+		$link2 = $document->getElementById("link2");
+		$sut->bind("url", "https://www.php.gt/", $link1);
+		$sut->bind("url", "https://www.php.gt/", $link2);
+		self::assertSame("https://www.php.gt/", $link1->textContent);
+		self::assertSame("https://www.php.gt/", $link2->href);
+		self::assertSame("https://www.php.gt/", $link1->href);
+		self::assertSame("https://www.php.gt/", $link2->textContent);
+	}
 }
diff --git a/test/phpunit/TestHelper/HTMLPageContent.php b/test/phpunit/TestHelper/HTMLPageContent.php
@@ -1101,6 +1101,13 @@ class HTMLPageContent {
 </ul>
 HTML;
 
+	const HTML_MULTIPLE_BIND_ATTRIBUTES = <<<HTML
+<!doctype html>
+<a id="link1" data-bind:text="url" data-bind:href="url" target="_blank" href="/">example.com</a>
+<a id="link2" data-bind:href="url" data-bind:text="url" target="_blank" href="/">example.com</a>
+HTML;
+
+
 	public static function createHTML(string $html = ""):HTMLDocument {
 		return new HTMLDocument($html);
 	}