Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement DICOM #60

Open
PiMaV opened this issue Oct 14, 2024 · 3 comments
Open

Reimplement DICOM #60

PiMaV opened this issue Oct 14, 2024 · 3 comments
Labels
feature-request New feature request

Comments

@PiMaV
Copy link
Owner

PiMaV commented Oct 14, 2024

This was disabled due to compiling reasons.
I'm open to the idea of DICOM and NON DICOM BLITZ with non-dicom being default.

Yet, we probably can find a way to make a single version work

@PiMaV PiMaV added the feature-request New feature request label Oct 14, 2024
@PiMaV
Copy link
Owner Author

PiMaV commented Nov 12, 2024

@irkri :
I have implemented DICOM now. Also according to our new loading schema.
You need to approve this. Yet I will not upload, as we have to talk first regarding packages. And there we have a bit of chaos, ragarding the new versions:

pylibjpeg 2.0.1
pylibjpeg-libjpeg 2.3.0
numba 0.60.0
numpy 2.0.2
gdcm 1.1

this was introduced, because we need:
pip pylibjpeg pylibjpeg-libjpeg gdcm pydicom

in theory thats fine; my version here (based on the latest 1.2.2) works fine with numpy 2

@irkri
Copy link
Collaborator

irkri commented Nov 20, 2024

I'm all in for using newest versions for numpy, hopefully version 2 is backwards compatible with the old one.

You can upload your code to a new branch, lets say v1.2.2-dicom, branched off of v1.2.2. Then I can check the code there.

@PiMaV
Copy link
Owner Author

PiMaV commented Nov 21, 2024

branched and uploaded !
So far no problems with numpy 2.
It seems backwards compatible at least for the stuff we are using

irkri added a commit that referenced this issue Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature request
Projects
None yet
Development

No branches or pull requests

2 participants