diff --git a/.github/workflows/build-jdk11.yaml b/.github/workflows/build-jdk11.yaml deleted file mode 100644 index 59e8167d8f..0000000000 --- a/.github/workflows/build-jdk11.yaml +++ /dev/null @@ -1,30 +0,0 @@ -name: Build with JDK 17 and test against JDK 11 -on: - pull_request: - push: - branches: [ master ] -permissions: - contents: read -jobs: - build: - runs-on: ubuntu-22.04 - steps: - # We run the build twice: once against the original Error Prone release, - # and once against the Picnic Error Prone fork. In both cases the code is - # compiled using JDK 17, while the tests are executed using JDK 11. - - name: Check out code and set up JDK and Maven - uses: s4u/setup-maven-action@fa2c7e4517ed008b1f73e7e0195a9eecf5582cd4 # v1.11.0 - with: - java-version: | - 11.0.20 - 17.0.8 - java-distribution: temurin - maven-version: 3.9.6 - - name: Display build environment details - run: mvn --version - - name: Build project against vanilla Error Prone - run: mvn -T1C install -Dsurefire.jdk-toolchain-version=11.0.20 - - name: Build project with self-check against Error Prone fork - run: mvn -T1C clean verify -Perror-prone-fork -Dsurefire.jdk-toolchain-version=11.0.20 -s settings.xml - - name: Remove installed project artifacts - run: mvn build-helper:remove-project-artifact diff --git a/README.md b/README.md index d9504bc996..2d06024f33 100644 --- a/README.md +++ b/README.md @@ -233,6 +233,18 @@ Other highly relevant commands: against _all_ code in the current working directory. For more information check the [PIT Maven plugin][pitest-maven]. +When running the project's tests in IntelliJ IDEA, you might see the following +error: + +``` +java: exporting a package from system module jdk.compiler is not allowed with --release +``` + +If this happens, go to _Settings -> Build, Execution, Deployment -> Compiler -> +Java Compiler_ and deselect the option _Use '--release' option for +cross-compilation (Java 9 and later)_. See [IDEA-288052][idea-288052] for +details. + ## 💡 How it works This project provides additional [`BugChecker`][error-prone-bugchecker] @@ -268,6 +280,7 @@ channel; please see our [security policy][security] for details. [github-actions-build-badge]: https://github.com/PicnicSupermarket/error-prone-support/actions/workflows/build.yml/badge.svg [github-actions-build-master]: https://github.com/PicnicSupermarket/error-prone-support/actions/workflows/build.yml?query=branch:master&event=push [google-java-format]: https://github.com/google/google-java-format +[idea-288052]: https://youtrack.jetbrains.com/issue/IDEA-288052 [license-badge]: https://img.shields.io/github/license/PicnicSupermarket/error-prone-support [license]: https://github.com/PicnicSupermarket/error-prone-support/blob/master/LICENSE.md [maven-central-badge]: https://img.shields.io/maven-central/v/tech.picnic.error-prone-support/error-prone-support?color=blue diff --git a/pom.xml b/pom.xml index 4a8ee5b4b3..5031c287c7 100644 --- a/pom.xml +++ b/pom.xml @@ -208,10 +208,7 @@ 2.24.1 0.1.22 1.0 - - 17 - 11 + 17 3.8.7 5.9.0 1.0.1 @@ -337,14 +334,6 @@ nopen-checker ${version.nopen-checker} - - - com.pkware.jabel - jabel-javac-plugin - 1.0.1-1 - com.uber.nullaway nullaway @@ -603,7 +592,7 @@ `provided`, but we'd rather not do that.) --> false false - ${version.jdk.target} + ${version.jdk} @@ -926,10 +915,6 @@ auto-service ${version.auto-service} - - com.pkware.jabel - jabel-javac-plugin - org.openrewrite rewrite-templating @@ -950,13 +935,9 @@ 10000 true + ${version.jdk} + ${version.jdk} false - - ${version.jdk.target} - ${version.jdk.target} false @@ -1033,7 +1014,7 @@ - ${version.jdk.target} + ${version.jdk} true @@ -1041,7 +1022,7 @@ src/main/resources/**/*.properties,src/test/resources/**/*.properties - ${version.jdk.source} + ${version.jdk} ${version.maven} @@ -1130,7 +1111,7 @@ the compilation phase; no need to recheck during Javadoc generation. --> none - ${version.jdk.source} + ${version.jdk} @@ -1369,7 +1350,7 @@ patterns in their `@BeforeTemplate` methods. --> tech.picnic.errorprone.refasterrules - ${version.jdk.target} + ${version.jdk} @@ -2000,19 +1981,8 @@ sonar - - - sonar.projectKey - - true - - ${version.jdk.source} @@ -2086,56 +2056,5 @@ - - - idea - - - idea.maven.embedder.version - - - - - - - org.apache.maven.plugins - maven-compiler-plugin - - ${version.jdk.source} - - - - - - - - custom-test-runtime-version - - - surefire.jdk-toolchain-version - - - - - - - org.apache.maven.plugins - maven-surefire-plugin - - - ${surefire.jdk-toolchain-version} - - - - - - -