Have ReverseOrder rule flag `Collections.reverseOrder(String::compa…

…reTo)`
PicnicSupermarket · Dec 8, 2022 · cf38b37 · cf38b37
1 parent b1c8157
commit cf38b37
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ComparatorRules.java b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ComparatorRules.java
@@ -58,6 +58,7 @@ static final class ReverseOrder<T extends Comparable<? super T>> {
     Comparator<T> before() {
       return Refaster.anyOf(
           Collections.reverseOrder(),
+          Collections.reverseOrder(T::compareTo),
           Collections.<T>reverseOrder(naturalOrder()),
           Comparator.<T>naturalOrder().reversed());
     }

diff --git a/...rib/src/test/resources/tech/picnic/errorprone/refasterrules/ComparatorRulesTestInput.java b/...rib/src/test/resources/tech/picnic/errorprone/refasterrules/ComparatorRulesTestInput.java
@@ -38,6 +38,7 @@ ImmutableSet<Comparator<String>> testNaturalOrder() {
   ImmutableSet<Comparator<String>> testReverseOrder() {
     return ImmutableSet.of(
         Collections.reverseOrder(),
+        Collections.reverseOrder(String::compareTo),
         Collections.<String>reverseOrder(naturalOrder()),
         Comparator.<String>naturalOrder().reversed());
   }

diff --git a/...ib/src/test/resources/tech/picnic/errorprone/refasterrules/ComparatorRulesTestOutput.java b/...ib/src/test/resources/tech/picnic/errorprone/refasterrules/ComparatorRulesTestOutput.java
@@ -33,7 +33,10 @@ ImmutableSet<Comparator<String>> testNaturalOrder() {
 
   ImmutableSet<Comparator<String>> testReverseOrder() {
     return ImmutableSet.of(
-        Comparator.reverseOrder(), Comparator.reverseOrder(), Comparator.reverseOrder());
+        Comparator.reverseOrder(),
+        Comparator.reverseOrder(),
+        Comparator.reverseOrder(),
+        Comparator.reverseOrder());
   }
 
   ImmutableSet<Comparator<String>> testCustomComparator() {