Update Checkstyle integration test #1424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary of changes: - Move Checkstyle-specific build parameters out of `run-integration-test.sh`. - Build with `-Dmaven.compiler.failOnError=true` to compensate for `<failOnError>false</failOnError>` configured by the enabled Maven profiles. - Tweak `XdocGenerator.java` logic prior to integration test execution, to work around a subtle semantic difference introduced by the `FilesCreateTempFileToFile` Refaster rule. - Document this difference on the relevant Refaster rules. - To aid debugging, run Maven commands with `set -x`, such that the exact command executed is logged. - Update the patch file containing the expected changes.
Stephan202
added
the
chore
|
Looks good. No mutations were possible for these changes. |
|
Stephan202
commented
Nov 17, 2024
Comment on lines
+137
to
+156
| --- a/src/test/java/com/puppycrawl/tools/checkstyle/internal/utils/XdocGenerator.java | ||
| +++ b/src/test/java/com/puppycrawl/tools/checkstyle/internal/utils/XdocGenerator.java | ||
| @@ -55,7 +55,8 @@ public final class XdocGenerator { | ||
| for (Path path : templatesFilePaths) { | ||
| final String pathToFile = path.toString(); | ||
| final File inputFile = new File(pathToFile); | ||
| - final File tempFile = File.createTempFile(pathToFile.replace(".template", ""), ""); | ||
| + final File outputFile = new File(pathToFile.replace(".template", "")); | ||
| + final File tempFile = File.createTempFile(outputFile.getName(), ""); | ||
| tempFile.deleteOnExit(); | ||
| final XdocsTemplateSinkFactory sinkFactory = (XdocsTemplateSinkFactory) | ||
| plexus.lookup(SinkFactory.ROLE, XDOCS_TEMPLATE_HINT); | ||
| @@ -70,7 +71,6 @@ public final class XdocGenerator { | ||
| finally { | ||
| sink.close(); | ||
| } | ||
| - final File outputFile = new File(pathToFile.replace(".template", "")); | ||
| final StandardCopyOption copyOption = StandardCopyOption.REPLACE_EXISTING; | ||
| Files.copy(tempFile.toPath(), outputFile.toPath(), copyOption); | ||
| } |
There was a problem hiding this comment.
I filed checkstyle/checkstyle#15935 to upstream these changes.
mohamedsamehsalah
approved these changes
Nov 17, 2024
rickie
approved these changes
Nov 17, 2024
|
/integration-test |
The check isn't listed under "All checks have passed", but it was successful. Will merge PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested commit message: