Python interrupt fix #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt200-ok
force-pushed
the
python-interrupt-fix
branch
from
291f9bc to
c05a53a
Compare
laves
requested changes
Jan 2, 2025
| @@ -0,0 +1,6 @@ | |||
| picollm==1.2.3 | |||
| pvcheetah==2.0.1 | |||
Comment on lines
+40
to
+42
| ``` | ||
|
|
||
| ## Custom Wake Word |
There was a problem hiding this comment.
I think you should add a section ## Config File to this and the other readme that explains the whole config file feature to a new user with a short example json block. Otherwise, the only exposure they have to it is the one sentence in the help text.
| @@ -0,0 +1,45 @@ | |||
| ## Compatibility | |||
There was a problem hiding this comment.
I think we should either have a title with a quick summary of what this demo is. Or, we could also put a readme at llm-voice-assistant/python that summarizes the differences between the demos (like we do in https://github.com/Picovoice/porcupine/tree/master/demo/android)
laves
requested changes
Jan 2, 2025
Co-authored-by: Ian Lavery <[email protected]>
laves
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.