Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial value for NumberTextHolder #54

Open
tiwanari opened this issue Oct 27, 2016 · 0 comments
Open

Initial value for NumberTextHolder #54

tiwanari opened this issue Oct 27, 2016 · 0 comments

Comments

@tiwanari
Copy link
Member

tiwanari commented Oct 27, 2016

This came from a discussion on #51 .

Problem

Our apps have NumberTextHolder and we set the initial value of it as 0 for time in the default strings.xml. However, it seems to be surprising for users because the value becomes, for example, 0.000 (i.e., it has more precisions) after changing its value.

In the current implementation, we should stick to 0 not 0.000 because there is a locale problem (e.g., in French, 0.000 should be 0,000) and this causes a conversion exception.

What we should do

As @Myusak suggested in the discussion, we can fix it by setting initial values in NumberTextHolders' constructor according to the Preference of their precision (this is a new feature). So, let's make such preference!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant