Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pingcap/tidb-operator): increase timeout for build jobs #1318

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

wuhuizuo
Copy link
Collaborator

@wuhuizuo wuhuizuo commented Nov 8, 2024

from 15 minutes to 30 minutes.

Signed-off-by: wuhuizuo [email protected]

from 15 minutes to 30 minutes.

Signed-off-by: wuhuizuo <[email protected]>
@ti-chi-bot ti-chi-bot bot requested a review from purelind November 8, 2024 05:53
@ti-chi-bot ti-chi-bot bot added area/apps env/prod will deploy on the main product cluster labels Nov 8, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 8, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and description, it seems that the timeout for build jobs in the pingcap/tidb-operator has been increased from 15 minutes to 30 minutes.

From the diff, it is clear that the timeout value has been updated from 15m to 30m in the git-create-tag.yaml and git-push.yaml files.

There don't seem to be any potential problems with this change. However, it is worth noting that increasing the timeout might lead to longer build times and higher resource utilization.

As for fixing suggestions, it would be helpful to update the documentation to reflect the new timeout value and to monitor the build times and resource utilization to ensure that they remain within acceptable limits.

@ti-chi-bot ti-chi-bot bot added the size/XS label Nov 8, 2024
Copy link
Collaborator Author

@wuhuizuo wuhuizuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

ti-chi-bot bot commented Nov 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 8, 2024
@ti-chi-bot ti-chi-bot bot merged commit 6bd9de4 into main Nov 8, 2024
4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/increase-tidb-operator-timeout branch November 8, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/apps env/prod will deploy on the main product cluster size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant