Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apps/prod/tekton/configs/triggers): fix tiup and fs triggers #1328

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

wuhuizuo
Copy link
Collaborator

Signed-off-by: wuhuizuo [email protected]

@ti-chi-bot ti-chi-bot bot requested a review from purelind November 12, 2024 09:45
@ti-chi-bot ti-chi-bot bot added area/apps env/prod will deploy on the main product cluster labels Nov 12, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 12, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request, the key changes are:

  • Renaming the trigger template name from push-oci-artifact-to-tiup-for-trunk-branches to push-oci-artifact-to-tiup.
  • Removing the trigger template for tags and replacing it with a trigger for file server.
  • Updating the tag matching regex in the artifact-push-on-harbor-forward-to-tiup trigger to include release branches.

There don't seem to be any potential problems with this pull request. However, I suggest the following fixing suggestions:

  • It would be better to provide a more detailed description of the changes made in the pull request.
  • Consider updating the trigger's name to reflect the new functionality. For example, artifact-push-on-harbor-forward-to-fs would be a more appropriate name for the trigger that forwards to the file server.
  • Consider updating the tag matching regex in the artifact-push-on-harbor-forward-to-tiup trigger to include other architectures apart from amd64 and linux.

@ti-chi-bot ti-chi-bot bot added the size/M label Nov 12, 2024
@wuhuizuo
Copy link
Collaborator Author

/approve

Copy link
Contributor

ti-chi-bot bot commented Nov 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 12, 2024
@ti-chi-bot ti-chi-bot bot merged commit 9de0155 into main Nov 12, 2024
4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/fs-trigger branch November 12, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/apps env/prod will deploy on the main product cluster size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant