Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(prod/jenkins-beta): read file credentials #1359

Merged

Conversation

purelind
Copy link
Contributor

@purelind purelind commented Dec 1, 2024

No description provided.

@ti-chi-bot ti-chi-bot bot requested a review from wuhuizuo December 1, 2024 07:34
@ti-chi-bot ti-chi-bot bot added the area/apps label Dec 1, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 1, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from purelind, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the env/prod will deploy on the main product cluster label Dec 1, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 1, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the title and the diff, it looks like the change is related to fixing a credential issue in the Jenkins configuration for the production environment. Specifically, it changes the way a secret is read by adding a base64 decoding step.

One potential problem is that we don't have enough context to understand why the original code used "${ks3util-config}" instead of "${base64:${ks3util-config}}". If there was a specific reason for this, the change may introduce new problems. It would be good to have more information about why this change was made.

Assuming that the change is necessary, one suggestion for improvement would be to add some documentation or comments to explain the reason for the change. This will make it easier for future maintainers to understand the code and avoid introducing new issues.

@purelind purelind merged commit 3e70fb5 into PingCAP-QE:main Dec 1, 2024
3 of 4 checks passed
@ti-chi-bot ti-chi-bot bot added the size/XS label Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/apps env/prod will deploy on the main product cluster size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant