Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency j3t/jenkins-pipeline-cache-plugin to v0.2.0 #432

Merged
merged 1 commit into from
Oct 29, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 23, 2023

Mend Renovate

This PR contains the following updates:

Package Update Change
j3t/jenkins-pipeline-cache-plugin minor 0.1.5 -> 0.2.0

Release Notes

j3t/jenkins-pipeline-cache-plugin (j3t/jenkins-pipeline-cache-plugin)

v0.2.0

Compare Source

Breaking changes

  • filter property has been renamed to includes and default excludes are not applied anymore
What's Changed

Full Changelog: j3t/jenkins-pipeline-cache-plugin@0.1.6...0.2.0

v0.1.6

Compare Source

What's Changed

Full Changelog: j3t/jenkins-pipeline-cache-plugin@0.1.5...0.1.6


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@ti-ee ti-ee bot requested review from jayl1e and purelind March 23, 2023 03:19
@ti-ee
Copy link
Contributor

ti-ee bot commented Mar 23, 2023

Hi @renovate[bot]. Thanks for your PR.

I'm waiting for a PingCAP-QE member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@renovate renovate bot force-pushed the renovate/j3t-jenkins-pipeline-cache-plugin-0.x branch from 1b99d78 to a4019ca Compare April 10, 2023 13:26
@ti-ee
Copy link
Contributor

ti-ee bot commented Apr 10, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: renovate[bot]
Once this PR has been reviewed and has the lgtm label, please assign wuhuizuo for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@renovate renovate bot force-pushed the renovate/j3t-jenkins-pipeline-cache-plugin-0.x branch 5 times, most recently from 40acc97 to 3a565c6 Compare April 18, 2023 10:53
@renovate renovate bot force-pushed the renovate/j3t-jenkins-pipeline-cache-plugin-0.x branch from 3a565c6 to eb900af Compare April 21, 2023 09:32
@ti-ee
Copy link
Contributor

ti-ee bot commented Apr 21, 2023

I have already done a preliminary review for you, and I hope to help you do a better job.


Pull Request Review

Changes Summary

This pull request updates the j3t/jenkins-pipeline-cache-plugin dependency from 0.1.5 to 0.2.0. The changes are as follows:

  • The filter property has been renamed to includes, and default excludes are not applied anymore.
  • A feature request has been added that supports GCS.

Potential Problems

The update could pose some issues as the filter property has been renamed, and this could break existing code that relies on filter. The team needs to ensure the code is compatible with the new version.

Fixing Suggestions

Review the relevant code and ensure that, where needed, the filter property has been refactored to specify the new include and exclude properties.

The team can also consider adding tests that cover the areas which could be affected by the change.

Additional Feedback

The PR description gives the relevant information, including the change log and release notes. It indicates which package has been updated, the new version, and any changes observed during the update.

Overall, the PR looks good to merge after addressing the potential problems.

@renovate renovate bot force-pushed the renovate/j3t-jenkins-pipeline-cache-plugin-0.x branch from eb900af to 9abe567 Compare April 22, 2023 15:06
@ti-ee
Copy link
Contributor

ti-ee bot commented Apr 22, 2023

I have already done a preliminary review for you, and I hope to help you do a better job.


Pull Request Review

The pull request updates the j3t/jenkins-pipeline-cache-plugin dependency from version 0.1.5 to 0.2.0. The update seems to be a minor release that includes some new features, breaking changes, and bug fixes.

The potential problems that could arise from the update are:

  • The filter property in cache configuration has been renamed to includes, and the default excludes are not applied anymore. This could lead to configuration issues if this property is not updated in the affected pipelines.
  • Any code that relies on the old features or the breaking changes could be impacted by the update.

To fix the problems mentioned above:

  • Update the pipeline configurations affected by the new includes property in the cache configuration.
  • Review the code to ensure no issues arise from the breaking or new changes.

Other than that, the update seems to be straight forward and does not introduce any major issues.

Suggestions

  • Add more information about how the updated version will benefit the project, if relevant.

@wuhuizuo wuhuizuo force-pushed the main branch 3 times, most recently from 5565434 to 367b190 Compare May 22, 2023 11:14
@wuhuizuo wuhuizuo force-pushed the main branch 4 times, most recently from a097282 to c412737 Compare June 4, 2023 07:16
@ti-chi-bot ti-chi-bot bot added the size/XS label Jun 19, 2023
@wuhuizuo wuhuizuo force-pushed the main branch 2 times, most recently from 8984fa7 to 4969c04 Compare July 2, 2023 09:59
@renovate renovate bot force-pushed the renovate/j3t-jenkins-pipeline-cache-plugin-0.x branch 2 times, most recently from 432ceb5 to faa6364 Compare October 5, 2023 17:51
@renovate renovate bot force-pushed the renovate/j3t-jenkins-pipeline-cache-plugin-0.x branch from f1cae10 to f5f7f86 Compare October 5, 2023 19:26
@wuhuizuo
Copy link
Collaborator

/hold it need to update all CI job configs

@wuhuizuo
Copy link
Collaborator

/ok-to-test

@renovate renovate bot force-pushed the renovate/j3t-jenkins-pipeline-cache-plugin-0.x branch from f5f7f86 to a0c4522 Compare October 20, 2023 02:41
@ti-chi-bot ti-chi-bot bot added area/apps env/prod will deploy on the main product cluster env/staging will deploy on staging cluster labels Oct 20, 2023
@wuhuizuo wuhuizuo force-pushed the main branch 8 times, most recently from c2e0850 to 00f574f Compare October 27, 2023 12:41
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 29, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-29 16:40:44.006461605 +0000 UTC m=+2798441.593571734: ☑️ agreed by wuhuizuo.

@ti-chi-bot ti-chi-bot bot added the approved label Oct 29, 2023
@wuhuizuo
Copy link
Collaborator

/unhold

@ti-chi-bot ti-chi-bot bot merged commit 590edb5 into main Oct 29, 2023
4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the renovate/j3t-jenkins-pipeline-cache-plugin-0.x branch October 29, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/apps env/prod will deploy on the main product cluster env/staging will deploy on staging cluster lgtm ok-to-test size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant