Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apps/prod/buildbarn): avoid scheduler pod on arm64 nodes #680

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

wuhuizuo
Copy link
Collaborator

@wuhuizuo wuhuizuo commented Sep 7, 2023

Signed-off-by: wuhuizuo [email protected]

@ti-chi-bot ti-chi-bot bot requested review from jayl1e and purelind September 7, 2023 12:20
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 7, 2023

I have already done a preliminary review for you, and I hope to help you do a better job.
Based on the pull request title and description, the proposed changes aim to avoid scheduler pod on arm64 nodes. The changes include adding a nodeSelector for amd64 architecture to several components.

Overall, the changes seem reasonable and straightforward, and the diff looks correct. However, some potential issues and suggestions can be made:

  • It is unclear why only amd64 architecture is specified for the nodeSelector. It would be helpful to add a comment or explanation in the code or pull request description.
  • It might be helpful to add a label to the nodes to specify the architecture, so that the nodeSelector can work correctly.
  • It would be better to test the changes on a cluster with both amd64 and arm64 architectures to ensure that the scheduler pod is not deployed on arm64 nodes.
  • The pull request description is not informative, and it would be helpful to add more details, such as the motivation for the changes, any issues or bugs that are fixed, or any potential impact on the system.

Overall, the changes seem to be straightforward, and no significant issues are apparent. However, it would be helpful to address the above suggestions to ensure that the changes work as intended and are well-documented.

@ti-chi-bot ti-chi-bot bot added the size/S label Sep 7, 2023
@wuhuizuo
Copy link
Collaborator Author

wuhuizuo commented Sep 7, 2023

/approve

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 7, 2023
@ti-chi-bot ti-chi-bot bot merged commit 667d84a into main Sep 7, 2023
3 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/apps/prod/buildbarn branch September 7, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant