Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(apps/gcp/prow/release): bump image for hook to v20230927-01102e9c12 #691

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

wuhuizuo
Copy link
Collaborator

  • tested in dev env.

Signed-off-by: wuhuizuo [email protected]

…e9c12`

- [x] tested in dev env.

Signed-off-by: wuhuizuo <[email protected]>
@ti-chi-bot ti-chi-bot bot requested review from jayl1e and purelind September 27, 2023 06:53
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 27, 2023

I have already done a preliminary review for you, and I hope to help you do a better job.

Review for GitHub Pull Request

Summary of Key Changes

The pull request aims to update the image for a hook in the apps/gcp/prow/release/release.yaml file. The image repository and tag have been updated from ticommunityinfra/hook:v20230922-c60c561dfe to ticommunityinfra/hook:v20230927-01102e9c12.

Potential Problems

There seem to be no potential problems with this pull request as it is a simple update of the image tag.

Fixing Suggestions

As there are no potential problems with this pull request, it can be approved and merged. Before merging, it is always recommended to ensure that the changes have been tested and that the code follows the best practices and coding standards.

@ti-chi-bot ti-chi-bot bot added the size/XS label Sep 27, 2023
@wuhuizuo
Copy link
Collaborator Author

wuhuizuo commented Sep 27, 2023

Test passed

OWNERS file: confg/OWNERS

# REF: https://www.kubernetes.dev/docs/guide/owners/#owners
options:
  no_parent_owners: true
filters:
  "config\\.toml\\.example$":
    approvers:
      - zuo-bot-1
  ".*":
    approvers:
      - zuo-bot-2

Changed files:

  • config/config.toml.example
  • config/hello.txt

Tests

  • Need approval for all all changed parts.
    image
  • parent owner has no effects when not inherit and with default regex set.
    image
  • all parts are approved.
    image

@wuhuizuo wuhuizuo added the lgtm label Sep 27, 2023
@wuhuizuo
Copy link
Collaborator Author

/approve

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 27, 2023
@ti-chi-bot ti-chi-bot bot merged commit 8a50ad6 into main Sep 27, 2023
3 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/apps/gcp/prow-bump-hook-image branch September 27, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant