Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apps/prod/jenkins-beta/release): use office image but not install latest version plugins #694

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

wuhuizuo
Copy link
Collaborator

@wuhuizuo wuhuizuo commented Oct 5, 2023

Changes

  1. Use office jenkins image rather than self build images.

Why

  1. I tested the plugins cli options and solved the issue with setting the install latest plugin option to false.

Signed-off-by: wuhuizuo [email protected]

@ti-chi-bot ti-chi-bot bot requested review from jayl1e and purelind October 5, 2023 17:18
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 5, 2023

I have already done a preliminary review for you, and I hope to help you do a better job.
Pull Request Summary:

This pull request aims to fix the Jenkins plugins installation by using the office image but not installing the latest version plugins.

Changes Made:

  • Added installLatestPlugins: false to not install the latest version of plugins.
  • Updated the list of plugins to be installed during Jenkins controller start.
  • Removed the image key from the controller object.
  • Updated the tag key of the controller object.

Potential Problems:

  • It is not clear why the image key was removed from the controller object. This change should be explained in the pull request description.
  • The image key was pointing to an internal image registry. This might not work for external users.
  • The version of the tag key in the controller object was changed without any explanation. This change should be explained in the pull request description.

Fixing Suggestions:

  • Add an explanation for the removal of the image key from the controller object.
  • Consider using a public image registry instead of an internal one.
  • Add an explanation for the change in the version of the tag key in the controller object.

@ti-chi-bot ti-chi-bot bot added the size/M label Oct 5, 2023
@wuhuizuo
Copy link
Collaborator Author

wuhuizuo commented Oct 5, 2023

/review default

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 5, 2023

@wuhuizuo:

I have already done a preliminary review for you, and I hope to help you do a better job.

Review

Summary

This pull request updates the Jenkins image used by the application, and also disables the installation of the latest version of plugins.

Potential Problems

It is not clear from the description whether this change has been tested thoroughly and if all the plugins are still working as expected. The pull request description also does not provide any information on why the change was made.

Suggestions

  • The pull request description should be more detailed and should include information on why the change was made, what problems it solves, and how it was tested.
  • It would be good to test all the plugins and make sure they work as expected with the new image and the disabled installation of latest version of plugins.
  • Consider adding comments in the code to explain why the changes were made and how they affect the application.

Conclusion

Overall, the changes look good, but more information and testing are needed before merging the pull request.

In response to this:

/review default

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wuhuizuo
Copy link
Collaborator Author

wuhuizuo commented Oct 5, 2023

/approve

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 5, 2023
@ti-chi-bot ti-chi-bot bot merged commit ff1f1b9 into main Oct 5, 2023
3 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/apps-prod-jenkins-beta branch October 5, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant