-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
real life diagrams - part 1 #68
Comments
Take 1: fail fast, fail cheap... svg: input: [
{
"iconDescription": "transport",
"iconKind": "Title",
"iconName": "1",
"iconNamesOfDependentIcons": [
"2"
]
},
{
"iconDescription": "Cryopreservation",
"iconKind": "Headline",
"iconName": "2",
"iconNamesOfDependentIcons": [
"3"
]
},
{
"iconDescription": "perfusion",
"iconKind": "Question",
"iconName": "3",
"iconNamesOfDependentIcons": [
"4",
"6"
]
},
{
"iconDescription": "perfuse the brain",
"iconKind": "Action",
"iconName": "4",
"iconNamesOfDependentIcons": [
"6"
]
},
{
"iconDescription": "The end",
"iconKind": "End",
"iconName": "6",
"iconNamesOfDependentIcons": []
}
] |
It's a problem with [
{
"icon": {
"iconDescription": "transport",
"iconKind": "Title",
"iconName": "1",
"iconNamesOfDependentIcons": [
"2"
]
},
"iconPositionX": 0,
"iconPositionY": 0
},
{
"icon": {
"iconDescription": "Cryopreservation",
"iconKind": "Headline",
"iconName": "2",
"iconNamesOfDependentIcons": [
"3"
]
},
"iconPositionX": 0,
"iconPositionY": -1
},
{
"icon": {
"iconDescription": "perfusion",
"iconKind": "Question",
"iconName": "3",
"iconNamesOfDependentIcons": [
"4",
"6"
]
},
"iconPositionX": 0,
"iconPositionY": -2
},
{
"icon": {
"iconDescription": "The end",
"iconKind": "End",
"iconName": "6",
"iconNamesOfDependentIcons": []
},
"iconPositionX": 0,
"iconPositionY": -3
},
{
"icon": {
"iconDescription": "perfuse the brain",
"iconKind": "Action",
"iconName": "4",
"iconNamesOfDependentIcons": [
"6"
]
},
"iconPositionX": 2,
"iconPositionY": -3
}
] |
Progress - I had a bug in the layout engine. It simply disregarded the order in which dependencies were defined. Resolved here: c0db4b3 But we have a new problem. Althought invisible, the connection between perfusion" question and "The end" does exist - it just runs in straight line behind "perfuse the brain" action icon which is incorrect. The expected behavior is that the connection should go around the action icon as in the original diagram. Will have to correct it next. |
Try to replicate a real life diagram:
source
The text was updated successfully, but these errors were encountered: