Skip to content

Commit 288c951

Browse files
committed
Fix update call in apibuild.py
There are still a few places where try/except is used for branching. This is a bad idea since it can hide errors like this one.
1 parent 92bb889 commit 288c951

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

doc/apibuild.py

+6-6
Original file line numberDiff line numberDiff line change
@@ -192,10 +192,10 @@ def add_ref(self, name, header, module, static, type, lineno, info=None, extra=N
192192
if name[0:2] == '__':
193193
return None
194194
d = None
195-
try:
195+
if name in self.identifiers:
196196
d = self.identifiers[name]
197-
d.update(header, module, type, lineno, info, extra, conditionals)
198-
except:
197+
d.update(header, module, type, info, extra, conditionals)
198+
else:
199199
d = identifier(name, header, module, type, lineno, info, extra, conditionals)
200200
self.identifiers[name] = d
201201

@@ -214,10 +214,10 @@ def add(self, name, header, module, static, type, lineno, info=None, extra=None,
214214
if name[0:2] == '__':
215215
return None
216216
d = None
217-
try:
217+
if name in self.identifiers:
218218
d = self.identifiers[name]
219-
d.update(header, module, type, lineno, info, extra, conditionals)
220-
except:
219+
d.update(header, module, type, info, extra, conditionals)
220+
else:
221221
d = identifier(name, header, module, type, lineno, info, extra, conditionals)
222222
self.identifiers[name] = d
223223

0 commit comments

Comments
 (0)