Skip to content

Commit bbb2b8f

Browse files
committed
Remove symbols from version script
The version script didn't account for symbols disabled by configuration options. This has caused problems on some OSs in the past and breaks lld 16 which enables --no-undefined-version by default. A proper fix would be rather involved, so we simply remove all symbols from the version script. This is an ELF-only feature and libxml2 never made use of symbol versioning anyway. Ultimately, this removes the need for a lot of bookkeeping without tangible benefits. We have to keep the version nodes to avoid errors when running binaries linked against older versions of libxml2. Fixes #473.
1 parent e6401b6 commit bbb2b8f

File tree

5 files changed

+48
-4223
lines changed

5 files changed

+48
-4223
lines changed

doc/Makefile.am

-5
Original file line numberDiff line numberDiff line change
@@ -58,19 +58,14 @@ dist_man_MANS = xml2-config.1 xmllint.1 xmlcatalog.1
5858

5959
EXTRA_DIST = \
6060
apibuild.py \
61-
checkapisym.xsl \
6261
libxml2-api.xml \
63-
symbols.xml \
64-
syms.xsl \
6562
xmlcatalog.xml \
6663
xmllint.xml
6764

6865
DOCBOOK_HTML = http://docbook.sourceforge.net/release/xsl/current/html/docbook.xsl
6966

7067
rebuild:
7168
cd $(srcdir) && ./apibuild.py
72-
cd $(srcdir) && $(XSLTPROC) checkapisym.xsl libxml2-api.xml
73-
cd $(srcdir) && $(XSLTPROC) -o ../libxml2.syms syms.xsl symbols.xml
7469
cd $(srcdir) && $(XSLTPROC) -o ../win32/libxml2.def.src ../win32/defgen.xsl libxml2-api.xml
7570
cd $(srcdir) && $(XSLTPROC) --nonet xmllint.xml
7671
cd $(srcdir) && $(XSLTPROC) --nonet -o xmllint.html $(DOCBOOK_HTML) xmllint.xml

doc/checkapisym.xsl

-48
This file was deleted.

0 commit comments

Comments
 (0)