Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potentially wrong parameter type in Custom Dimension service - deleteCustomDimension method #9

Open
akurdyk opened this issue Aug 16, 2022 · 0 comments
Open

Potentially wrong parameter type in Custom Dimension service - deleteCustomDimension method #9

akurdyk opened this issue Aug 16, 2022 · 0 comments
Assignees
@danieltwork

Comments

@akurdyk
Copy link

akurdyk commented Aug 16, 2022

In Custom Dimension service function deleteCustomDimension have parameter customDimensionId typed as string but rest of the functions type that param as string | number. In the JavaScript client documentation there is another version that param should be number. I guess it should be unified.

https://developers.piwik.pro/en/latest/data_collection/web/javascript_tracking_client/api.html#custom-dimensions
https://github.com/PiwikPRO/react-piwik-pro#custom-dimensions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danieltwork danieltwork

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danieltwork @akurdyk