-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autodesk: Fix MSVC build with pch #3120
Closed
erikaharrison-adsk
wants to merge
1
commit into
PixarAnimationStudios:dev
from
autodesk-forks:adsk/bugfix/fix-windows-pch
Closed
Autodesk: Fix MSVC build with pch #3120
erikaharrison-adsk
wants to merge
1
commit into
PixarAnimationStudios:dev
from
autodesk-forks:adsk/bugfix/fix-windows-pch
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikaharrison-adsk
changed the title
Autodesk: Support MSVC build with pch
Autodesk: Fix MSVC build with pch
Jun 13, 2024
Filed as internal issue #USD-9754 |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
2 tasks
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
dgovil
added
build
Build-related issue/PR
needs review
Issue needing input/review by the repo maintainer (Pixar)
labels
Oct 23, 2024
This fixes #3408 |
Looks like this is a duplicate of #3204 which has been merged in to the dev branch. I'm closing this for now, but feel free to reopen if you continue to have issues! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Fix Windows build failure when PCH is ON when using ninja.
Fixes Issue(s)