Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autodesk: Fix MSVC build with pch #3120

Conversation

erikaharrison-adsk
Copy link
Contributor

@erikaharrison-adsk erikaharrison-adsk commented Jun 12, 2024

Description of Change(s)

Fix Windows build failure when PCH is ON when using ninja.

Fixes Issue(s)

  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@erikaharrison-adsk erikaharrison-adsk changed the title Autodesk: Support MSVC build with pch Autodesk: Fix MSVC build with pch Jun 13, 2024
@jesschimein
Copy link
Contributor

Filed as internal issue #USD-9754

@jesschimein
Copy link
Contributor

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jesschimein
Copy link
Contributor

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jesschimein
Copy link
Contributor

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dgovil dgovil added build Build-related issue/PR needs review Issue needing input/review by the repo maintainer (Pixar) labels Oct 23, 2024
@DDoS
Copy link
Contributor

DDoS commented Nov 22, 2024

This fixes #3408

@pixar-oss
Copy link
Member

Looks like this is a duplicate of #3204 which has been merged in to the dev branch. I'm closing this for now, but feel free to reopen if you continue to have issues!

@pixar-oss pixar-oss closed this Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build-related issue/PR needs review Issue needing input/review by the repo maintainer (Pixar)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants