nonLockingLinux__execve: Use register for ARM asm(reg) vars #3275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes broken build with `clang -Werror` on ARM.
Variables assigned to a register with `asm()` (like `asm("x0")`) should be `register` not automatic.
https://gcc.gnu.org/onlinedocs/gcc/Local-Register-Variables.html
clang emits a warning for this, which will turn into an error with `-Werror`. gcc emits no warning/error.
https://godbolt.org/z/4zE94szzo
|
Filed as internal issue #USD-10087 ❗ Please make sure that a signed CLA has been submitted! |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
I work for Google, which you can verify with https://github.com/jmr. As I understand it, Google already has a corporate CLA on file. |
|
Hi @jmr! Thank you for the PR! We actually need names submitted by the corporate point of contact (or someone with authority to grant copyright/patent permissions) to be part of the Corporate CLA. Could you please have them email usd-cla (at) pixar (dot) com to add your name to the schedule? Thank you! |
This has been done now. |
|
This seems to be the same issue as #3008 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Variables assigned to a register with
asm()(likeasm("x0")) should beregisternot automatic.https://gcc.gnu.org/onlinedocs/gcc/Local-Register-Variables.html
clang emits a warning for this, which will turn into an error with
-Werror. gcc emits no warning/error.https://godbolt.org/z/4zE94szzo
Fixes Issue(s)
Fixes broken build with
clang -Werroron ARM.I have verified that all unit tests pass with the proposed changes
I have submitted a signed Contributor License Agreement