You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The model is currently structured to calculate each of the components for the duration of the simulation and then stick them together to do the N balance. This worked well when the model was quite simple. However, we have had to add more complexity into the loss model and feedbacks to reduce uptake if soil N is limited which has resulted in a code structure that is quite hard to read.
It would be better to turn this into a true daily time-step model so it is easier to follow for others needing to ready of debug the code in the future.
The text was updated successfully, but these errors were encountered:
An issue emerged with mass balance breaking if an actual fertiliser event was entered after a test value had been entered. This was fixed by PR #64 but this test has broken some bits of the testing system. Specifically, crop N uptake when fert is not scheduled is calculated before actual fertiliser events are applied and not update after actual fertiliser is applied so the results look bad. A convoluted series of roll back/update calculations was attempted but it became to complex. Better to refactor the core model so it can deal effectively with the demands that have emerged for it (i.e to do a full N balance including losses in both retrospective {testing} and forecast {schedulling} situations.
The model is currently structured to calculate each of the components for the duration of the simulation and then stick them together to do the N balance. This worked well when the model was quite simple. However, we have had to add more complexity into the loss model and feedbacks to reduce uptake if soil N is limited which has resulted in a code structure that is quite hard to read.
It would be better to turn this into a true daily time-step model so it is easier to follow for others needing to ready of debug the code in the future.
The text was updated successfully, but these errors were encountered: