Chore: Model Code Refactor #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support tickets
Nibble-Byte
changed the title
|
2 failed unit tests
I encountered this issue with my own fork. I think you might need to look at this one @HamishBrownPFR. Maybe some missing data? |
|
@JBris / @HamishBrownPFR That failing unit test should pass now. Hamish and I need to have a call on monday/tuesday to discuss some of the changes I made. |
|
okay, all unit tests have passed. Will leave it to you to make the approval @HamishBrownPFR |
HamishBrownPFR
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.