Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto remove the contamination? #19

Open
GallVp opened this issue Apr 17, 2023 · 3 comments
Open

Auto remove the contamination? #19

GallVp opened this issue Apr 17, 2023 · 3 comments
Labels
question Further information is requested

Comments

@GallVp
Copy link
Member

GallVp commented Apr 17, 2023

No description provided.

@GallVp
Copy link
Member Author

GallVp commented Apr 17, 2023

It's not that easy. People might make a mistake on the TRIM action: https://github.com/ncbi/fcs/wiki/FCS-adaptor#rules-for-action-assignment

@GallVp
Copy link
Member Author

GallVp commented Apr 17, 2023

Add a responsibility statement.

@GallVp GallVp added the v2 label Jun 8, 2023
@GallVp GallVp removed the v2 label Apr 16, 2024
@GallVp
Copy link
Member Author

GallVp commented Apr 23, 2024

Please see point 3 here: https://github.com/ncbi/fcs/wiki/FCS-GX-quickstart#usage-examples

By default the NCBI GX tool hard masks internal contaminants. Hard masking already has multiple meaning. First, it can represent a gap. Second, it can represent hard masking by a tool such as repeat masker. Now with this, it can also mean hard masking due to contamination.

Some suggestions:

  1. Adaptors should be removed by the assembler software.
  2. Foreign organism contamination should be removed following the recommendations from NCBI FCS GX (https://github.com/ncbi/fcs/wiki/FCS-GX-output#fcs-gx-action-report), except for the FIX action for internal contaminations. Instead of hard masking the contamination, we should insert 100 N's there to denote a gap of unknown size.

@GallVp GallVp changed the title Auto remove the contamination Auto remove the contamination? May 6, 2024
@GallVp GallVp added the question Further information is requested label May 6, 2024
@GallVp GallVp added this to the backlog milestone May 22, 2024
@GallVp GallVp removed this from the backlog milestone Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant