Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant code to compute position vector #1597

Open
3 tasks
unalmis opened this issue Feb 19, 2025 · 0 comments
Open
3 tasks

Remove redundant code to compute position vector #1597

unalmis opened this issue Feb 19, 2025 · 0 comments
Labels
P1 Lowest Priority, will get to eventually

Comments

@unalmis
Copy link
Collaborator

unalmis commented Feb 19, 2025

  • Add position compute quantity for all objects X = (R, phi, Z)
  • Change existing position computations to require R, phi, Z dependencies rather than recomputing transforms
  • Remove redundant code of constructing position array from R, phi, Z everywhere with just call to compute X
@unalmis unalmis added the P1 Lowest Priority, will get to eventually label Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P1 Lowest Priority, will get to eventually
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@unalmis