Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Tab title not localise #1154

Open
2 of 3 tasks
vernak2539 opened this issue Jan 6, 2025 · 0 comments
Open
2 of 3 tasks

[BUG] Tab title not localise #1154

vernak2539 opened this issue Jan 6, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@vernak2539
Copy link

What happened?

When creating new tabs with a localised extension, the tab title isn't localised. This makes the browser's page title look something like this:

Screenshot 2025-01-06 at 16 15 26

It looks like this is due to how the scaffolder generates the HTML by simply inserting the value in the manifest.

I'm unsure how to go about fixing this. Since the title is generated during build (basically static) and HTML doesn't allow for a form of interpolation, it seems that this may have to be done in user land based on the framework one is using (react, svelte, etc.)?

Would love to know how anyone else has gotten this working!

Version

Latest

What OS are you seeing the problem on?

Windows, MacOSX, Linux

What browsers are you seeing the problem on?

Chrome, Microsoft Edge

Relevant log output

No response

(OPTIONAL) Contribution

  • I would like to fix this BUG via a PR

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I checked the current issues for duplicate problems.
@vernak2539 vernak2539 added the bug Something isn't working label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant