Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V solutions no longer build #980

Closed
rbergen opened this issue Oct 20, 2024 · 1 comment · Fixed by #982
Closed

V solutions no longer build #980

rbergen opened this issue Oct 20, 2024 · 1 comment · Fixed by #982

Comments

@rbergen
Copy link
Contributor

rbergen commented Oct 20, 2024

Both solutions in the V language (as submitted by @marghidanu and @GordonBGood) fail to build since recently, due to a deprecation that apparently should become an error per 01-01-2025, but already causes builds to fail now.

The error reported on PrimeV/solution_1 during CI is as follows:

#13 [build 4/4] RUN v -prod primes.v
#13 0.142 primes.v:28:1: notice: `[attr]` has been deprecated, use `@[attr]` instead
#13 0.142    26 | }
#13 0.142    27 | 
#13 0.142    28 | [direct_array_access]
#13 0.142       | ^
#13 0.142    29 | fn (mut sieve Sieve) run_sieve() {
#13 0.142    30 |     mut factor := u64(3)
#13 0.245 primes.v:4:1: error: const () groups will be an error after 2025-01-01 (`v fmt -w source.v` will fix that for you)
#13 0.245     2 | import math
#13 0.245     3 | 
#13 0.245     4 | const (
#13 0.245       | ~~~~~
#13 0.245     5 |     sieve_size          = 1_000_000
#13 0.245     6 |     q                   = math.sqrt(sieve_size)
#13 ERROR: process "/bin/sh -c v -prod primes.v" did not complete successfully: exit code: 1

I will open a PR to remove the V solutions from the CI and daily benchmark runs, until a PR has been submitted and merged that addresses this problem. I would prefer one PR to address the issue in both solutions, but I will accept single-solution fixes and unblock CI and benchmark runs accordingly.

@rbergen
Copy link
Contributor Author

rbergen commented Oct 20, 2024

@marghidanu provided a proper solution in #982. This issue will be closed when that gets merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant