Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest Julia version to represent current performance #972

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

christiangnrd
Copy link
Contributor

@christiangnrd christiangnrd commented Aug 6, 2024

Description

This PR updates the version of Julia used in all 4 solutions from 1.6 to 1.10. 1.10 will be the next long-term support release once 1.11 releases in a few weeks, and while I don't think there's a big change in performance, it is more representative of current Julia performance.

@dcbi, @epithet, @louie-github, @GordonBGood

@rbergen
Copy link
Contributor

rbergen commented Aug 6, 2024

@christiangnrd Thanks for opening this! It's nice to have someone (else) concern themselves with some of the "regular maintenance" a project like this requires. :)

I'll give the people you tagged a week or so to respond before moving towards merging.

@christiangnrd
Copy link
Contributor Author

I tried to make the least amount of changes to ensure this gets merged, but I personally think we should be using the latest stable version, as recommended on the downloads page. That would mean using the 1/1-alpine tags instead of 1.10/1.10-alpine.

Curious about your opinion.

@rbergen
Copy link
Contributor

rbergen commented Aug 6, 2024

In principle everything is good to merge as long as an actual version tag is used (i.e. anything but "latest"). There are no set rules for how specific that version tag needs to be.

However, the more flexibility you allow in the tag's exact version interpretation, the bigger the chance that some future specific version within the range you specify will break (a) build(s) at some point. And if that happens in a way that makes CI fail I'll do what it takes and what I think is best to fix that, right then and there. And that may not be what you (or a solution contributor) prefers.

In that non-negotiable context, it is up to you. :)

@christiangnrd
Copy link
Contributor Author

That sounds reasonable. The second sentence in the linked downloads pages mentions "Great care is taken not to break compatibility with older Julia versions, so older code should continue to work with the latest stable Julia release.", so I think it's worth the risk.

I pushed a change to use the latest stable version. If any of the original authors objects I'll change it back for their solution.

@rbergen
Copy link
Contributor

rbergen commented Aug 13, 2024

In the absence of feedback from solution authors and considering CI passes without any hiccups, I'm merging this.

@rbergen rbergen merged commit de1a34f into PlummersSoftwareLLC:drag-race Aug 13, 2024
165 checks passed
rbergen added a commit that referenced this pull request Oct 20, 2024
* Use latest Julia version to represent current performance (#972)

* Use latest Julia version to represent current performance

* Use latest stable 1.X version

* Add timeout to benchmark solution runs (#977)

* Added formatting and removed deprecated attributes syntax (#982)

Co-authored-by: Tudor Marghidanu <[email protected]>

---------

Co-authored-by: Christian Guinard <[email protected]>
Co-authored-by: Tudor Marghidanu <[email protected]>
Co-authored-by: Tudor Marghidanu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants