Add Conway support, Replace Plutip with cardano-testnet #1624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge develop to master
v8.0.0 release
Ogmios doesn't work with long paths.
Ignore empty (corrupted) Ogmios fixtures.
…aryData Add scripts to `AuxiliaryData` in query layer
…args-2 Update uplc-apply-args
errfrom
changed the title
klntsky
reviewed
Jul 29, 2024
Comment on lines
+10
to
+11
| The use of [Plutip](https://github.com/mlabs-haskell/plutip) in CTL is | ||
| deprecated. For information on how to test with the Cardano Testnet, please |
There was a problem hiding this comment.
Suggested change
| The use of [Plutip](https://github.com/mlabs-haskell/plutip) in CTL is | |
| deprecated. For information on how to test with the Cardano Testnet, please | |
| The use of [Plutip](https://github.com/mlabs-haskell/plutip) in CTL for testing is | |
| discontinued in favor of `cardano-testnet` integration. For information on how to test with the Cardano Testnet, please |
klntsky
reviewed
Jul 29, 2024
| @@ -9,6 +9,7 @@ | |||
|
|
|||
| inputs = { | |||
| nixpkgs.follows = "haskell-nix/nixpkgs-unstable"; | |||
| nixpkgs-arion.url = "github:NixOS/nixpkgs"; | |||
klntsky
reviewed
Jul 29, 2024
| chromium | ||
| python38 # To serve bundled CTL | ||
| python39 # To serve bundled CTL |
klntsky
reviewed
Jul 29, 2024
| <<< Array.fromFoldable | ||
| <<< Map.values | ||
|
|
||
| -- FIXME: adjust values |
klntsky
reviewed
Jul 29, 2024
| Just (PaymentCredential (PubKeyHashCredential pkh)) -> | ||
| case mSkh of | ||
| Nothing -> | ||
| Constraints.mustPayToPubKey $ wrap pkh |
There was a problem hiding this comment.
These are now deprecated with a type-level warning. Please use the underlying data constructors so that the warning is not propagated to the call site
klntsky
reviewed
Jul 29, 2024
| withStakeKey :: PrivateStakeKey -> InitialUTxOs -> InitialUTxOsWithStakeKey | ||
| withStakeKey = InitialUTxOsWithStakeKey | ||
|
|
||
| privateStakeKeyForDist :: PrivateStakeKey |
klntsky
reviewed
Jul 29, 2024
| CTL depends on a number of binaries in the `$PATH` to execute tests on the | ||
| Cardano Testnet: | ||
|
|
||
| - [`cardano-node`](https://github.com/IntersectMBO/cardano-node) to connect to the Cardano Testnet |
There was a problem hiding this comment.
Suggested change
| - [`cardano-node`](https://github.com/IntersectMBO/cardano-node) to connect to the Cardano Testnet | |
| - [`cardano-node`](https://github.com/IntersectMBO/cardano-node) to connect to the Cardano Testnet | |
| - `cardano-testnet` | |
| - `cardano-cli` |
klntsky
reviewed
Jul 29, 2024
| If you have based your project on the [`ctl-scaffold` | ||
| template](../templates/ctl-scaffold) then you have two options to run tests on | ||
| the Cardano Testnet: | ||
| 1. `nix develop` followed by `npm run test` (recommended for development) |
There was a problem hiding this comment.
Suggested change
| 1. `nix develop` followed by `npm run test` (recommended for development) | |
| 1. `nix develop` followed by `npm run testnet-test` (recommended for development) |
klntsky
reviewed
Jul 29, 2024
doc/cardano-testnet-testing.md
Outdated
| 2. `nix run .#checks.x86_64-linux.ctl-scaffold-local-testnet-test` | ||
| * where you'd usually replace `x86_64-linux` with the system you run tests on | ||
| * and `ctl-scaffold-local-testnet-test` with the name of the test derivation for your project; | ||
| * note that building of your project via Nix will fail in case there are any PureScript compile-time warnings. |
There was a problem hiding this comment.
Suggested change
| * note that building of your project via Nix will fail in case there are any PureScript compile-time warnings. |
It will be obvious anyway if there are errors. No need to overload users with info before it's needed
klntsky
reviewed
Jul 30, 2024
| @@ -832,6 +832,9 @@ absTimeFromRelTime (EraSummary { start, end }) (RelTime relTime) = do | |||
|
|
|||
| wrap <$> (liftM CannotGetBigIntFromNumber $ BigInt.fromNumber absTime) | |||
|
|
|||
| slotLengthFactor :: Number | |||
There was a problem hiding this comment.
Is this value affected by protocol parameters?
- remove excessive logging in cardano-testnet - apply more relaxed process.setMaxListeners limits
35 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the work from #1593
Closes #1622
Closes #1564
Closes #1631
Dependencies
Breaking Changes
mustIncludeDatumconstraintExamples (Ogmios + Kupo, SanchoNet, Eternl Beta):
AdditionalUtxosAlwaysMintsAlwaysSucceeds(OgmiosError { code: 3113, data: (Just {"providedScriptIntegrity":"15dd0a3ac1244430aacc7e95c2734b51f1a8cf2aaf05e5d6e8124cb78ab54cc9","computedScriptIntegrity":"5675d0b3607627653b48941ade5477ac756c58188547e7753be8b38243fb9fe4"})...IncludeDatumexample fails with the same error. Although the corresponding test against local testnet cluster succeeds.AlwaysSucceedsV2ApplyArgsChangeGeneration1-1ChangeGeneration1-3ChangeGeneration3-1Cip30DropTokensMintsMultipleTokensNativeScriptMintsOneShotMintingOneShotMintingV2PaysWithDatumPkh2PkhReferenceInputsAndScriptsOgmiosError { code: 3113, data: (Just {"providedScriptIntegrity":"a238e08fe55c3ebb72d04c08d7622c02e07bfe93a06ae27244c27d6eb40b6025","computedScriptIntegrity":"5feb905325a9c6a378adf7c23fb11837486d550f8a2fb1a23db86ab221fa43fa"}...ECDSAIncludeDatumOgmiosError { code: 3113, data: (Just {"providedScriptIntegrity":"0916f53e560760d110c0cfdd9626361129d9144cb0c1828525ce2698978ee969","computedScriptIntegrity":"ad869d3e9a101d1e9f3cfd146904aae1855beb3ffe323870eea9b0e5ae652707"}...SchnorrSendsTokenSignDataSignMultipleTxChainingUtxosScript evaluation failure while trying to estimate ExUnits. ... ValidatorFailed { error: "An error has occurred: User error:\nThe machine terminated because of an error, either from a built-in function or from an explicit use of 'error'.", traces: ["Utxo not consumed"] }WalletPre-review checklist
make format)templates/ctl-scaffold) has been updated## Unreleasedheader, using the appropriate sub-headings (### Added,### Changed,### Removed,### Fixed), and the links to the appropriate issues/PRs have been included