build: pass site & base options on build command

https://docs.astro.build/en/guides/deploy/github/#configure-astro-for-github-pages
PokeAPI · Feb 4, 2025 · 700f254 · 700f254
1 parent 45b8a1b
commit 700f254
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/.github/workflows/pages.yml b/.github/workflows/pages.yml
@@ -38,7 +38,8 @@ jobs:
       - name: Install dependencies
         run: npm ci
       - name: Build with Astro
-        run: BASE_URL='pokeapi.co' npm run build
+        # run: BASE_URL='https://pokeapi.github.io/' npm run build
+        run: npm run build --site 'https://pokeapi.github.io/' --base 'pokeapi.co'
       - name: Upload artifact
         uses: actions/upload-pages-artifact@v3
         with:
@@ -54,4 +55,4 @@ jobs:
     steps:
       - name: Deploy to GitHub Pages
         id: deployment
-        uses: actions/deploy-pages@v4
+        uses: actions/deploy-pages@v4
diff --git a/astro.config.mjs b/astro.config.mjs
@@ -3,11 +3,11 @@ import starlight from '@astrojs/starlight'
 import starlightOpenAPI, { openAPISidebarGroups } from 'starlight-openapi'
 import tailwindcss from '@tailwindcss/vite'
 
-const base_url = process.env.BASE_URL || ''
+// const base_url = process.env.BASE_URL || ''
 
 export default defineConfig({
   site: 'https://pokeapi.co',
-  base: base_url,
+  base: '/pokeapi.co'
   integrations: [
     starlight({
       title: 'PokéAPI',
@@ -26,7 +26,8 @@ export default defineConfig({
         // Generate the OpenAPI documentation pages.
         starlightOpenAPI([
           {
-            base: `${base_url}/v2/openapi`,
+            // base: `${base_url}/v2/openapi`,
+            base: `/v2/openapi`,
             label: 'OpenAPI',
             schema: 'https://raw.githubusercontent.com/PokeAPI/pokeapi/master/openapi.yml',
           },