Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.19.2 Update #266

Open
Ledix5 opened this issue Sep 17, 2022 · 7 comments
Open

1.19.2 Update #266

Ledix5 opened this issue Sep 17, 2022 · 7 comments

Comments

@Ledix5
Copy link

Ledix5 commented Sep 17, 2022

Do you plan to update the mod to 1.19.2?

@Pokechu22
Copy link
Owner

I want to at some point, but do not have an ETA, and the update to 1.17+ is difficult due to internal changes to how the game works.

@StereoMadnessss
Copy link

also is there a fabric port

@milutinke
Copy link

If you have some time, you could make a simple manual about the code base and resources that need to be used, someone else might be able to contribute.
I also would like to, I already have some MC experience working with the MCC, but I have no clue about Forge, but given some time I probably would learn it.
What are the technical difficulties with the 1.17.1?

@BookWyrm114
Copy link
Contributor

I think they explained it in some other issues but if I Rember correctly it's mainly due to changes with forgegradle, the height limit changes in 1.17+, and also because of trying to build the mod to work across multiple versions at once

@Pokechu22
Copy link
Owner

Oh, sorry, yes, I missed this. The ForgeGradle part is the biggest one, but the others are also issues.

The mod's code itself is fairly well documented with javadoc comments; the highest-level overview is that mixins or patches are used to call code in WDLHooks.java, then WDLHooks.java does a bit of state management and calls WDLEvents.java, which calls out to a bunch of other code (including the code that handles copying inventories to block entities). Most state is stored in WDL.java (perhaps a bit too much state, is there). I don't think it should be too hard to navigate.

The build system is much less well documented, and I don't really remember how much of it works, unfortunately :/

@uyjulian
Copy link
Collaborator

Yeah mainly the problem is incompatible ForgeGradle versions and the maven repos and other remote dependencies may no longer be up.

I pretty much dropped off the Minecraft modding scene after LiteLoader stopped updating and I couldn’t be bothered to learn the new Fabric or whatever system is being used nowadays.

@BookWyrm114
Copy link
Contributor

There does exist a similar mod for fabric called “Chunkcopy” that’s open-source, it’s been updated to 1.19.2 but now seems to have been abandoned, if you know enough to continue support for that you could maybe ask the author for permission to do so. It has most of WDL’s features, but instead of saving the downloaded worlds to a singleplayer world, you have to make a world and run a command to paste the chunks. It likely wouldn’t be super hard to add an option to save the chunks to singleplayer worlds automatically like WDL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants