pa court scraper issue #239 #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeldepace
requested review from
josh-chamberlain and
mbodeantor
as code owners
|
thanks, @michaeldepace ! There are a bunch of ways I could see proceeding—for now, I made a commit on your branch to add the envar (hope that's OK) and I added it as a repo-level secret. I'll reach out about meeting to discuss. |
There was a problem hiding this comment.
Could you add some instructions here?
- making and activating a venv solves install problems and requirements conflicts most of the time, we usually ask people to do that. I ran:
python3 -m venv venv
source venv/bin/activate
-
could you add a requirements.txt, and give people instructions to install that way?
-
I had to create a /data folder, could you add a blank one to the template?
other than that, it seems to work!
josh-chamberlain
approved these changes
May 21, 2024
josh-chamberlain
merged commit 05bd38b
into
Police-Data-Accessibility-Project:main
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #239