Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

secure-fetch does not save fetched tags. #44

Open
gchronis opened this issue Oct 6, 2017 · 0 comments
Open

secure-fetch does not save fetched tags. #44

gchronis opened this issue Oct 6, 2017 · 0 comments

Comments

@gchronis
Copy link
Contributor

gchronis commented Oct 6, 2017

While doing some acceptance testing for git-promote, I keep failing on the merge step. The script acts like the pre-release tag is successfully fetched, but then fails on the merge step (i.e. merging devel tag into release branch), complaining that ERROR: merge: v1 - not something we can merge. The problem stems from fetching tags by name rather than all at once.
By name (v1 is a remote tag):

gchronis@gchronis:~/dotfiles$ git fetch origin v1
From github.com:gchronis/dotfiles
 * tag               v1         -> FETCH_HEAD
gchronis@gchronis:~/dotfiles$ git tag   
gchronis@gchronis:~/dotfiles$

All at once:

gchronis@gchronis:~/dotfiles$ git fetch --tags
From github.com:gchronis/dotfiles
 * [new tag]         v1         -> v1
gchronis@gchronis:~/dotfiles$ git tag
v1

We need to fetch tags by explicitly by name in order to ensure that their fetch and push histories are recorded in the RSL. The problem is that fetching tags by name doesn't create a local ref automatically, they way fetching branches does. We will need to create a reference to the FETCH_HEAD, possibly using one of the strategies listed here https://stackoverflow.com/questions/45338495/fetch-a-single-tag-from-remote-repository.

@gchronis gchronis changed the title secure-fetch does not fetch tags. secure-fetch does not save fetched tags. Oct 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant