Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🎸 return decrypted amount and balance via proof server #28

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

polymath-eric
Copy link
Collaborator

@polymath-eric polymath-eric commented Aug 20, 2024

JIRA Link

DA-1269

Changelog / Description

return decrypted amounts for /incoming-balances/apply endpoint when the public key is present in the proof server

Checklist -

  • New Feature ?
  • Updated swagger annotation (if API structure is changed) ?
  • Unit Test (if possible) ?
  • Updated the Readme.md (if required) ?

return decrypted amounts for /incoming-balances/apply endpoint when the
public key is present in the proof server
Copy link

Copy link

@prashantasdeveloper prashantasdeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But we can also add the decryption in other endpoints as well. Can be done later maybe.

Base automatically changed from return-sender-proofs to alpha August 24, 2024 12:55
@prashantasdeveloper
Copy link

/fast-forward

@polymath-eric polymath-eric merged commit 15d892b into alpha Sep 4, 2024
7 checks passed
@polymath-eric polymath-eric deleted the return-decrypted-balance branch September 4, 2024 16:43
@polymesh-bot
Copy link

🎉 This PR is included in version 1.1.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@polymesh-bot
Copy link

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants