From 1ac7b6467eb241cb26563cdfdc8d077ea82f9c83 Mon Sep 17 00:00:00 2001
From: Eric Richardson <eric@polymesh.network>
Date: Wed, 15 May 2024 17:03:10 -0400
Subject: [PATCH] =?UTF-8?q?fix:=20=F0=9F=90=9B=20allow=20non-agents=20to?=
 =?UTF-8?q?=20pre-approve=20assets?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

correct authorization logic that was preventing non asset agents from
pre-approving assets
---
 src/api/procedures/__tests__/toggleTickerPreApproval.ts | 4 ++--
 src/api/procedures/toggleTickerPreApproval.ts           | 7 +++----
 2 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/src/api/procedures/__tests__/toggleTickerPreApproval.ts b/src/api/procedures/__tests__/toggleTickerPreApproval.ts
index e36abfa53f..c2f9f720cf 100644
--- a/src/api/procedures/__tests__/toggleTickerPreApproval.ts
+++ b/src/api/procedures/__tests__/toggleTickerPreApproval.ts
@@ -121,7 +121,7 @@ describe('toggleTickerPreApproval procedure', () => {
       expect(boundFunc(args)).toEqual({
         permissions: {
           transactions: [TxTags.asset.PreApproveTicker],
-          assets: [expect.objectContaining({ ticker })],
+          assets: [],
           portfolios: [],
         },
       });
@@ -131,7 +131,7 @@ describe('toggleTickerPreApproval procedure', () => {
       expect(boundFunc(args)).toEqual({
         permissions: {
           transactions: [TxTags.asset.RemoveTickerPreApproval],
-          assets: [expect.objectContaining({ ticker })],
+          assets: [],
           portfolios: [],
         },
       });
diff --git a/src/api/procedures/toggleTickerPreApproval.ts b/src/api/procedures/toggleTickerPreApproval.ts
index 53eff06c5a..1615dae452 100644
--- a/src/api/procedures/toggleTickerPreApproval.ts
+++ b/src/api/procedures/toggleTickerPreApproval.ts
@@ -1,4 +1,4 @@
-import { BaseAsset, PolymeshError, Procedure } from '~/internal';
+import { PolymeshError, Procedure } from '~/internal';
 import { ErrorCode, TxTags } from '~/types';
 import { ExtrinsicParams, ProcedureAuthorization, TransactionSpec } from '~/types/internal';
 import { stringToTicker } from '~/utils/conversion';
@@ -56,15 +56,14 @@ export async function prepareToggleTickerPreApproval(
  */
 export function getAuthorization(
   this: Procedure<Params, void>,
-  { ticker, preApprove }: Params
+  { preApprove }: Params
 ): ProcedureAuthorization {
-  const { context } = this;
   return {
     permissions: {
       transactions: [
         preApprove ? TxTags.asset.PreApproveTicker : TxTags.asset.RemoveTickerPreApproval,
       ],
-      assets: [new BaseAsset({ ticker }, context)],
+      assets: [],
       portfolios: [],
     },
   };