Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change log level to warn when experience continuity is enabled #82

Open
tim-golioth opened this issue Sep 13, 2023 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@tim-golioth
Copy link

Is your feature request related to a problem?

The current SDK (we're using the Go SDK) logs a message at the level of ERROR when a flag has experience continuity enabled. The log message looks like this:

posthog 2023/09/13 15:20:25 ERROR: Unable to compute flag locally - Flag has experience continuity enabled

Unless I'm reading the docs incorrectly, or misunderstanding the experience continuity feature, an actual error did not occur. Rather, the log statement is simply noting that flags are not being evaluated locally, but being evaluated by 1 or more calls to Posthog. Thus, depending on the number of flags defined, the application could experience performance issues.

Describe the solution you'd like

The problem with logging the above statement at the ERROR level is that it gives the false impression that some kind of error occurred. It'd be helpful to change this statement to be more accurate. Some options that I can think of:

  • change the log level to WARN
  • if this statement is indicative of an error condition being present, rephrase the message to include more specifics about the actual error
  • add more context to the message to say something like, "...Flag has experience continuity enabled and may cause performance issues in flag evaluation"

Thanks for all the hard work you all put into Posthog!

@tim-golioth tim-golioth added the enhancement New feature or request label Sep 13, 2023
@neilkakkar
Copy link
Contributor

makes a lot of sense, thanks @tim-golioth

@dmarticus dmarticus transferred this issue from PostHog/posthog Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants