Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor network logs instrumentation for session replay #204

Open
marandaneto opened this issue Oct 2, 2024 · 0 comments · May be fixed by #260
Open

Refactor network logs instrumentation for session replay #204

marandaneto opened this issue Oct 2, 2024 · 0 comments · May be fixed by #260

Comments

@marandaneto
Copy link
Member

Description

Relates to PostHog/posthog-js-lite#276
#203 is a quick fix but instrumentation should be reworked so we instrument the datatask methods without a completion handler but we are still able to collect the right duration.
There are a few ways (and more complex) of doing this, such as instrumenting the delegate methods, wrapping the completion handlers, instrumenting the URLProtocol for complete control, etc.
My idea is to borrow the logic if possible from https://github.com/kasketis/netfox.
They do this in all possible ways and its a well known lib

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant