Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Update upload-artifact and download-artifact to version 4 #13679

Merged
merged 1 commit into from
Jan 9, 2024
Merged

ci: Update upload-artifact and download-artifact to version 4 #13679

merged 1 commit into from
Jan 9, 2024

Conversation

rgacogne
Copy link
Member

@rgacogne rgacogne commented Jan 8, 2024

Short description

Supersedes #13636 and #13637.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added the ci label Jan 8, 2024
@rgacogne rgacogne added this to the common-soon milestone Jan 8, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7450165341

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 57.696%
Totals Coverage Status
Change from base Build 7448235306: 0.02%
Covered Lines: 107743
Relevant Lines: 155393
💛 - Coveralls

@rgacogne rgacogne requested review from Habbie and romeroalx January 9, 2024 08:12
romeroalx
romeroalx approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@romeroalx romeroalx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rgacogne rgacogne merged commit df8b067 into PowerDNS:master Jan 9, 2024
75 checks passed
@rgacogne rgacogne deleted the update-upload-download-artifact branch January 9, 2024 09:24
This was referenced Dec 2, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romeroalx romeroalx romeroalx approved these changes

@Habbie Habbie Awaiting requested review from Habbie

Assignees
No one assigned
Labels
ci
Projects
None yet
Milestone
common-soon
Development

Successfully merging this pull request may close these issues.
3 participants
@rgacogne @coveralls @romeroalx