Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide checkbox option to use PSReadline beta version #5098

Open
2 tasks done
thegraffix opened this issue Nov 19, 2024 · 3 comments
Open
2 tasks done

Provide checkbox option to use PSReadline beta version #5098

thegraffix opened this issue Nov 19, 2024 · 3 comments
Labels
Area-PSReadLine Issue-Enhancement A feature request (enhancement). Up for Grabs Will shepherd PRs.

Comments

@thegraffix
Copy link

Prerequisites

  • I have written a descriptive issue title.
  • I have searched all issues to ensure it has not already been reported.

Summary

The option to choose between stable and beta releases of PSReadline would be helpful.

Proposed Design

  • Install both the latest stable and beta versions of the PSReadline module side by side.
  • Add a checkbox in the VSCode options:
    [√] Use PSReadline beta version (default value of "checked")
@thegraffix thegraffix added Issue-Enhancement A feature request (enhancement). Needs: Triage Maintainer attention needed! labels Nov 19, 2024
@JustinGrote
Copy link
Collaborator

JustinGrote commented Nov 20, 2024

This would probably end up being a bug farm, but as a workaround, you can run Open Extensions Folder in the command palette, then go to ms-vscode.powershell/modules folder and remove and replace the PSReadline that is there. Should work fine, though you'll probably also want to pin your extension version and update manually after each update.

I'm going to flag it as Up for Grabs, but any setting needs to come with a very clear disclaimer. We also aren't going to ship beta psreadline in the extension as that is unnecessary bloat (though we do ship betas in the module on occasion as the primary version) so the implementation would need to find the psreadline beta or otherwise specify its path manually.

@JustinGrote JustinGrote added Area-PSReadLine Up for Grabs Will shepherd PRs. and removed Needs: Triage Maintainer attention needed! labels Nov 20, 2024
@thegraffix
Copy link
Author

In fact that's exactly what I'm doing right now, replacing the existing PSReadline 2.4.0 folder with the latest stable version (2.3.6 right now). Initially, I was a bit confused as to why a PSReadline beta was included to begin with -- so thank you for the explanation 🙂 All of that makes perfect sense.

@andyleejordan
Copy link
Member

@SydneyhSmith can you expand on the reason we included the beta for the last few releases? I noticed there have been a few stable releases since, though of the 2.3 series, not 2.4. What were we gaining with 2.4?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-PSReadLine Issue-Enhancement A feature request (enhancement). Up for Grabs Will shepherd PRs.
Projects
None yet
Development

No branches or pull requests

3 participants