Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]:Fix Navbar and Responsiveness #357

Merged

Conversation

shreyash3087
Copy link
Contributor

This PR fixes the Navbar along with the responsiveness of the website,previously the website had problems with navbar and the responsiveness.The content on smaller screen was overflowing which was reducing the overall user experience for smaller devices.

Issue number

closes: #335

Video/Screenshots (mandatory)

Bug -

Bug.mp4

Fix-

Fix.mp4

Screenshots of Fixed Responsiveness-

Iphone SE-

screencapture-localhost-5174-2024-06-05-19_32_29

Checklist:

  • I have mentioned the issue number in my Pull Request.
  • I have commented my code, particularly in hard-to-understand areas
  • I have gone through the contributing.md file before contributing

Additional context:

N/A

Copy link

vercel bot commented Jun 5, 2024

@shreyash3087 is attempting to deploy a commit to the pranavbarthwal's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

github-actions bot commented Jun 5, 2024

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, you can contact the mentors for this project.

@shreyash3087
Copy link
Contributor Author

@surajvast1 kindly verify the changes,also has any recent commits done by maintaners made some changes to the background color of this website,the light purple background color isnt there on currently deployed website,but if you fork this repo and run it locally there is light purple background.

@shreyash3087
Copy link
Contributor Author

shreyash3087 commented Jun 5, 2024

also as soon as i cloned this repo i got this error-

Error

which i fixed,it was just a duplicate assignment error-

Screenshot (200)
screencapture-github-PranavBarthwal-cosmoXplore-commit-c399f12aa1135830e148eaeb055619e6fdab9c84-2024-06-05-20_08_34

Notice CreateBrowser line was assigned multiple times,but its alright,was just a small fix,but im still unsure who changed the background color and is it intended or a mistake.If it was a mistake i can fix it,if its intended i'll leave it.

@surajvast1
Copy link
Collaborator

We saw this issue .It will be fixed by today and you may pull the changes and modify your images up here

Copy link
Owner

@PranavBarthwal PranavBarthwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work, just resolve the conflicts

@shreyash3087
Copy link
Contributor Author

@PranavBarthwal it should be good now,can you verify.

thankyou

Copy link

vercel bot commented Jun 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cosmo-xplore ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 8, 2024 6:49pm

@PranavBarthwal PranavBarthwal merged commit 92d6ca4 into PranavBarthwal:main Jun 8, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Navbar Hamburger doesn't work properly
3 participants