Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enhancing Nav Bar #382

Merged

Conversation

thecloudcode
Copy link
Contributor

@thecloudcode thecloudcode commented Jun 9, 2024

Enhancing Nav Bar

This PR adds the glass effect to the navbar and improves the css by updating the Navbar.jsx and Navbar.css files.

Issue number

closes: #298

Video/Screenshots (mandatory)

After my changes :

navbar.update.-.thecloudcode.mp4

Screenshot 2024-06-09 094432

Before
image

Checklist:

  • I have mentioned the issue number in my Pull Request.
  • I have commented my code, particularly in hard-to-understand areas
  • I have gone through the contributing.md file before contributing

Additional context:

N/A

Copy link

vercel bot commented Jun 9, 2024

@thecloudcode is attempting to deploy a commit to the pranavbarthwal's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

github-actions bot commented Jun 9, 2024

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, you can contact the mentors for this project.

Copy link

vercel bot commented Jun 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cosmo-xplore ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 9, 2024 9:33am

@PranavBarthwal PranavBarthwal merged commit 502efc2 into PranavBarthwal:main Jun 9, 2024
2 of 4 checks passed
@surajvast1
Copy link
Collaborator

Because of this merge we have lost our responsiveness of the navbar .It was my mistake to approve this.I take full responsibility
Reverting changes create a new pr @thecloudcode

@surajvast1
Copy link
Collaborator

@PranavBarthwal Revert this

@surajvast1 surajvast1 added invalid This doesn't seem right wontfix This will not be worked on labels Jun 10, 2024
@PranavBarthwal
Copy link
Owner

@PranavBarthwal Revert this

Cant be reverted now, lets create a new issue to fix the responsiveness.

This was referenced Jun 10, 2024
@surajvast1
Copy link
Collaborator

surajvast1 commented Jun 10, 2024

@PranavBarthwal merge changes by @DonaldReddy .he created the pr first
here
#388

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancing Nav Bar
3 participants