Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiLanguage Facility #469

Merged
merged 4 commits into from
Jul 31, 2024
Merged

MultiLanguage Facility #469

merged 4 commits into from
Jul 31, 2024

Conversation

Ojas-Arora
Copy link
Contributor

@Ojas-Arora Ojas-Arora commented Jul 29, 2024

Title of Issue and Pull Request must be Same

@PranavBarthwal @surajvast1 I have added MultiLanguage Facility to website. Kindly review this.

Issue number

closes: #443

Video/Screenshots (mandatory)

Checklist:

  • I have mentioned the issue number in my Pull Request.
  • I have commented my code, particularly in hard-to-understand areas
  • I have gone through the contributing.md file before contributing

Additional context:

Copy link

vercel bot commented Jul 29, 2024

@Ojas-Arora is attempting to deploy a commit to the pranavbarthwal's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, you can contact the mentors for this project.

@Ojas-Arora
Copy link
Contributor Author

@PranavBarthwal @surajvast1 Kindly please merge the PR as soon as possible as Gssoc is about to end in few days.

@Ojas-Arora
Copy link
Contributor Author

@PranavBarthwal @surajvast1 Kindly please merge the PR till tomorrow as after that will be the last day

@Ojas-Arora
Copy link
Contributor Author

@PranavBarthwal @surajvast1 Sir event is about to end kindly do so

@Ojas-Arora
Copy link
Contributor Author

@PranavBarthwal @surajvast1 Sir please its a request

@PranavBarthwal
Copy link
Owner

@PranavBarthwal @surajvast1 Sir please its a request

Reviewing brother.

Copy link

vercel bot commented Jul 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cosmo-xplore ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2024 6:22pm

@Ojas-Arora
Copy link
Contributor Author

Thanks sir

Copy link
Owner

@PranavBarthwal PranavBarthwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you style that dropdown button according to website's theme and place it in navbar next to contact us.

Rest is fine, once this is done do tag me, I'll merge.
Good work!

@Ojas-Arora
Copy link
Contributor Author

@PranavBarthwal ok

@Ojas-Arora
Copy link
Contributor Author

@PranavBarthwal Done

@Ojas-Arora
Copy link
Contributor Author

@PranavBarthwal Kindly review this

@Ojas-Arora
Copy link
Contributor Author

Ojas-Arora commented Jul 30, 2024

@PranavBarthwal @surajvast1 Kindly see the latest one

Copy link
Owner

@PranavBarthwal PranavBarthwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix this, and improve its style

image

@Ojas-Arora
Copy link
Contributor Author

@PranavBarthwal Ok sir i will fix this and sir style of the multilanguage option cant be changes it is made just like this

@PranavBarthwal
Copy link
Owner

@PranavBarthwal Ok sir i will fix this and sir style of the multilanguage option cant be changes it is made just like this

I see. So just add this in the footer
Below copyright statement.
In the center.

@Ojas-Arora
Copy link
Contributor Author

@PranavBarthwal ok

@Ojas-Arora
Copy link
Contributor Author

@PranavBarthwal Done sir kindly review.

@Ojas-Arora
Copy link
Contributor Author

@PranavBarthwal Is this ok now?

@surajvast1
Copy link
Collaborator

Review it and merge this @PranavBarthwal

@PranavBarthwal PranavBarthwal merged commit d883f80 into PranavBarthwal:main Jul 31, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MultiLanguage Facility
3 participants