-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pydantic V2 support #23
Comments
@michaelfeil @atmiguel @mhaligowski Would you be able to help get #27 merged? |
It would be great to get these conflicts resolved! |
Related: latest version 1.12.0 made Haystack tests fail on Python 3.9 with Link to failing CI: https://github.com/deepset-ai/haystack-core-integrations/actions/runs/9039411463 |
@masci thanks, I missed that |
It seems maintainers have no interest in addressing this. I will likely resolve this by removing dependency. |
Apologies for the delayed reply. Unfortunately, the ".v1" hack only works for pydantic 1.10.15 and above so this would be a breaking change right now. However, we are working with users who may be affected to upgrade to at least that version. We hope to release a fix on our end once that wraps up. ETA ~ 2 weeks. Sorry for the inconvenience in the meantime.
|
@ml2 Appreciate the update! I'll close out my PR. |
We have deployed the change allowing customers above 1.10.15 to use V1 and the rest to use V2. Let us know if you have any issues |
Can we add support for pydantic V2? Even by using their v1 compatibility layer? It causes some packaging issues downstream
The text was updated successfully, but these errors were encountered: